Calling sharing_add_footer after (!) wp_print_footer_scripts in wp_footer to ensure jQuery dependancy

[kasparsd]

Currently sharing_add_footer is being attached to wp_footer with priority 10 which is before WordPress has printed the footer scripts as wp_print_footer_scripts is attached to wp_footer with priority 20.

sharing_add_footer echoes inline Javascript during display_footer() (here is an example) which depends on jQuery being already available. This fails in cases when jQuery is enqueued in the footer.

The solution is to move sharing_add_footer to a later priority:

add_action( 'wp_footer', 'sharing_add_footer', 25 );

[ronalfy]

+1 for this. Alternative is to remove the footer calls and use the wp_enqueue_scripts hook and do:

global $wp_scripts;
$wp_scripts->add_data( 'jquery', 'data', $jetpack_sharing_scripts );

I can submit a pull request if this would be ideal. A drawback is that the scripts will show up in the header if jQuery is enqueued in the header.

[ronalfy]

An elegant baked-in solution would be nice. Too many hacks in this script to get this to work with enqueuing: https://gist.github.com/ronalfy/3d5de0527095ff00907b

[cfxd]

@kasparsd @ronalfy

Just wanted to bump this, since it's causing jQuery console errors in themes with jQuery properly enqueued in the footer.

Perhaps we can get a temporary fix as @kasparsd suggested of changing the action priority?

My git is acting funny but a PR would be much appreciated!

[dboulet]

I’m still seeing this issue with Jetpack 3.9.6 and WP 4.5. Changing the action priority of sharing_add_footer() won’t work, because it itself enqueues another script.

In WP 4.5, there is wp_add_inline_script(), which could possibly be used to fix this. Is that doable? Is Jetpack required to support older versions of WP?

https://developer.wordpress.org/reference/functions/wp_add_inline_script/

[jeherve]

Is Jetpack required to support older versions of WP?

Yes, we aim for Jetpack to be compatible with the current version and one major version before that, so we'll need to wait for WordPress 4.6 to be released before to require 4.5+.

[jeherve]

Also reported in 59964-zd-vip

[kasparsd]

I updated my original report with a link to the actual script from Share_Email which calls the jQuery directly.

[grappler]

Yes, we aim for Jetpack to be compatible with the current version and one major version before that, so we'll need to wait for WordPress 4.6 to be released before to require 4.5+.

@jeherve 4.7 has been released so we could create a PR for this?

[kasparsd]

@jeherve I think the JS document.getElementById('jetpack-source_f_name').value = '' isn't needed anymore since the value of that field is no longer set to hello.

[jeherve]

@grappler Yes. It looks like @kasparsd already took care of it (thank you!). You can test #6339 and give your feedback there if you'd like!

[jeherve]

Reopening as we had to revert this in #6649.

This was explained in #6641.

Next steps to get this fixed once and for all are described here:
#6641 (comment)

[aheckler]

3128393-t

[lamdayap]

related: link

[stale]

This issue has been marked as stale. This happened because:

• It has been inactive in the past 6 months.
• It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.