Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted part of the changes introduced in #6339. #6649

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Reverted part of the changes introduced in #6339. #6649

merged 1 commit into from
Mar 14, 2017

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Mar 14, 2017

Fixes #6640

Changes proposed in this Pull Request:

Testing instructions:

  • Enable sharing buttons for your site.
  • Ensure that clicking them opens a new smaller window instead of opening full new tab.

@zinigor zinigor added [Feature] Sharing Post sharing, sharing buttons [Pri] BLOCKER [Status] Has Changelog [Status] Needs Review This PR is ready for review. [Type] Bug When a feature is broken and / or not performing as intended labels Mar 14, 2017
@zinigor zinigor added this to the 4.7.1 milestone Mar 14, 2017
@zinigor zinigor self-assigned this Mar 14, 2017
@zinigor zinigor requested review from jeherve and eliorivero March 14, 2017 13:59
@zinigor
Copy link
Member Author

zinigor commented Mar 14, 2017

Partially borrows from #6641

@jeherve jeherve mentioned this pull request Mar 14, 2017
Open
jeherve
jeherve approved these changes Mar 14, 2017
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to merge! 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 14, 2017
@eliorivero
Copy link
Contributor

It's good. Will merge once Travis ends.

@eliorivero eliorivero merged commit e3c8abe into master Mar 14, 2017
@eliorivero eliorivero deleted the fix/revert-sharing-6339 branch March 14, 2017 14:18
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 14, 2017
@eliorivero
Copy link
Contributor

PR description references #6639 but it actually is #6339

@dereksmart
Copy link
Member

in branch-4.7 c813ec2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@eliorivero eliorivero eliorivero approved these changes

Assignees

@zinigor zinigor

Labels
[Feature] Sharing Post sharing, sharing buttons [Pri] BLOCKER Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@zinigor @eliorivero @dereksmart @jeherve @matticbot