-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enqueue jQuery in the header #1445
Conversation
Make sure that jQuery is enqueued in the header to resolve #1223
Hrm. I'd sooner see enqueueing it as a dependency properly, but we'll see if this way is required. Need further investigation internally first. |
There may be a more elegant solution but I couldn't locate it. The problem only began after I disabled several Jetpack modules I wasn't using (Beautiful Math, Gravatar Hovercards, JSON API, and Shortcode Embeds). Prior to disabling these modules jQuery was getting loaded in the head and the inline javascript in the footer from the sharedaddy module ran fine. |
Are you using any other plugins? What version of Jetpack are you running? It's possible that something is glitching. |
Jetpack 3.3. Other active plugins: Akismet 3.0.4, BackUpWordPress 3.0.4, Disqus Comment System 2.84, Use Google Libraries 1.6.2, WordPress SEO 1.7.1, WP Crontrol 1.2.3, WP Super Cache 1.4.2. I rolled my change back to the original implementation on my sandbox site and verified the problem existed (jQuery in the footer below the inline sharedaddy javascript). Then I re-enabled the Jetpack modules I turned off today. With either Gravatar Hovercards or Shortcode Embeds enabled jQuery gets loaded in the head. Edit: Forgot to mention that I also tried disabling the other plugins with the aforementioned Jetpack modules disabled and jQuery was still loaded in the footer so I'm not sure it's a plugin conflict. |
@georgestephanis, what would you like to do on this? |
I'll take a look tomorrow to see what's causing jQuery to not be loaded -- or rather what script is expecting it but not getting it. |
I'm closing this, as we took a different swing at it in #1666 which got merged. |
Make sure that jQuery is enqueued in the header to resolve #1223