Change "sharing_add_footer" priority to temporarily fix jQuery undefined console errors when using ShareDaddy with jQuery enqueued in the footer (#1223) #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned console errors when using ShareDaddy with jQuery enqueued in the footer
jeherve
added
[Type] Enhancement
|
works for me... |
samhotchkiss
added a commit
that referenced
this pull request
Feb 26, 2015
…-priority Change "sharing_add_footer" priority to temporarily fix jQuery undefined console errors when using ShareDaddy with jQuery enqueued in the footer (#1223)
|
👍 |
|
fyi I had to revert this commit in d396079. It caused the sharing library not to be enqueued at all in my tests. As soon as the priority was higher than |
|
How can I resubmit the PR with priority 20? Should I create a new branch/PR from scratch? |
Yep, that'd be the best way. |
|
Done @ #1700 |
|
Should have tested before I submitted, but priority 19 causes the undefined issue. 20 does not. |
|
OK, I'll do some digging on this next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1223