Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract ABSStore to zarr._storage.absstore #781

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

joshmoore
Copy link
Member

First step towards being able to assign CODEOWNERS
to simplify maintenance. This does not yet attempt
the rename to zarr.storage.absstore in order lower
conflicts with open PRs. Imports should remain un-
changed for the moment.

see: #764

@joshmoore joshmoore force-pushed the extract-abstore branch 2 times, most recently from a3debbb to eb35f72 Compare June 17, 2021 08:38
First step towards being able to assign CODEOWNERS
to simplify maintenance. This does not yet attempt
the rename to zarr.storage.absstore in order lower
conflicts with open PRs. Imports should remain un-
changed for the moment.

see: zarr-developers#764
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #781 (d7d7f41) into master (efd94fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #781   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          28       29    +1     
  Lines       10562    10568    +6     
=======================================
+ Hits        10556    10562    +6     
  Misses          6        6           
Impacted Files Coverage Δ
zarr/_storage/absstore.py 100.00% <100.00%> (ø)
zarr/storage.py 100.00% <100.00%> (ø)

@joshmoore joshmoore mentioned this pull request Jun 17, 2021
@joshmoore
Copy link
Member Author

Re-opening to see if this goes green.

@joshmoore joshmoore closed this Aug 9, 2021
@joshmoore joshmoore reopened this Aug 9, 2021
@joshmoore joshmoore merged commit 45c1783 into zarr-developers:master Aug 10, 2021
@joshmoore joshmoore deleted the extract-abstore branch August 10, 2021 09:22
@joshmoore
Copy link
Member Author

Note: this PR missed needs a commit to add zarr._storage to packages. Pushed directly as 2241a26

Without this commit,

          python -m pip install git+https://github.com/zarr-developers/zarr-python.git@master

fails with:

>>> import zarr
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/anaconda3/envs/z/lib/python3.9/site-packages/zarr/__init__.py", line 3, in <module>
    from zarr.convenience import (consolidate_metadata, copy, copy_all, copy_store,
  File "/usr/local/anaconda3/envs/z/lib/python3.9/site-packages/zarr/convenience.py", line 7, in <module>
    from zarr.core import Array
  File "/usr/local/anaconda3/envs/z/lib/python3.9/site-packages/zarr/core.py", line 32, in <module>
    from zarr.storage import array_meta_key, attrs_key, getsize, listdir
  File "/usr/local/anaconda3/envs/z/lib/python3.9/site-packages/zarr/storage.py", line 59, in <module>
    from zarr._storage.absstore import ABSStore  # noqa: F401
ModuleNotFoundError: No module named 'zarr._storage'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants