Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store refactor #764

Closed
jakirkham opened this issue Jun 2, 2021 · 12 comments
Closed

Store refactor #764

jakirkham opened this issue Jun 2, 2021 · 12 comments

Comments

@jakirkham
Copy link
Member

During the Zarr meeting today, we discussed splitting out the various Stores in storage.py into separate files (ideally in a Python storage package taking the place of storage.py). This should make it easier to identify relevant people to get feedback from when making changes to a specific Store. Would be good to hear others thoughts on this idea 🙂
@jakirkham
Copy link
Member Author

@joshmoore please feel free to add anything else here I may have forgotten

@joshmoore
Copy link
Member

Thanks, @jakirkham. I'll just add:

  • The motivation from my side was: Update ABSStore for compatibility with newer azure.storage.blob. #759
  • I merged without knowing much (...cough... anything) about the implementation and/or PR.
  • With some research (or in this case, with John's help) the people who did know were identified.
  • But if we could do that using a GH mechanism, it would make maintenance much easier.

@jakirkham
Copy link
Member Author

cc @zarr-developers/core-devs (in case anyone has thoughts on this)

@rabernat
Copy link
Contributor

rabernat commented Jun 2, 2021 •
edited
Loading

I think this is an excellent idea and I support it 💯 . The storage module is way too big / complicated. I would imagine something like this

storage/__init__.py
storage/base.py
storage/directory_store.py
storage/zip_store.py
etc.

@martindurant
Copy link
Member

Sounds reasonable

joshmoore added a commit to joshmoore/zarr-python that referenced this issue Jun 17, 2021
@joshmoore
Extract ABSStore to zarr._storage.absstore
88e1ee4 
First step towards being able to assign CODEOWNERS
to simplify maintenance. This does not yet attempt
the rename to zarr.storage.absstore in order lower
conflicts with open PRs. Imports should remain un-
changed for the moment.

see: zarr-developers#764
This was referenced Jun 17, 2021
Merged
Closed
joshmoore added a commit to joshmoore/zarr-python that referenced this issue Jun 17, 2021
@joshmoore
Extract ABSStore to zarr._storage.absstore
a3debbb 
First step towards being able to assign CODEOWNERS
to simplify maintenance. This does not yet attempt
the rename to zarr.storage.absstore in order lower
conflicts with open PRs. Imports should remain un-
changed for the moment.

see: zarr-developers#764
joshmoore added a commit to joshmoore/zarr-python that referenced this issue Jun 17, 2021
@joshmoore
Extract ABSStore to zarr._storage.absstore
eb35f72 
First step towards being able to assign CODEOWNERS
to simplify maintenance. This does not yet attempt
the rename to zarr.storage.absstore in order lower
conflicts with open PRs. Imports should remain un-
changed for the moment.

see: zarr-developers#764
joshmoore added a commit to joshmoore/zarr-python that referenced this issue Jun 17, 2021
@joshmoore
Extract ABSStore to zarr._storage.absstore
9028d6f 
First step towards being able to assign CODEOWNERS
to simplify maintenance. This does not yet attempt
the rename to zarr.storage.absstore in order lower
conflicts with open PRs. Imports should remain un-
changed for the moment.

see: zarr-developers#764
@joshmoore
Copy link
Member

So, looking at #759, who should be listed as a CODEOWNER in #781? @jhamman and @shikharsg?

Also: do we want to create a team ("@zarr-developers/azure-team") or list individually?

@jhamman
Copy link
Member

jhamman commented Jun 17, 2021

Happy either way. If listing individually, @shikharsg, @tjcrone, @TomAugspurger, and myself are the likely candidates.

@joshmoore
Copy link
Member

  • A pro of a team is it lets people remove themselves
  • A pro of individuals is better visibility of additions/removals

@shikharsg
Copy link
Contributor

Although I'm happy to be listed as an individual, I would personally prefer a team. Having changed jobs a few months ago I no longer have access to a large azure subscription where I can test this stuff at scale, and have to make do with my laptop.

@joshmoore
Copy link
Member

@zarr-developers/azure-team now setup.

@joshmoore
Copy link
Member

#781 is ready for review if someone wants to have a go.

joshmoore added a commit that referenced this issue Aug 10, 2021
@joshmoore
Extract ABSStore to zarr._storage.absstore (#781)
45c1783 
* Extract ABSStore to zarr._storage.absstore

First step towards being able to assign CODEOWNERS
to simplify maintenance. This does not yet attempt
the rename to zarr.storage.absstore in order lower
conflicts with open PRs. Imports should remain un-
changed for the moment.

see: #764

* Ignore unused import

* Register absstore.py in CODEOWNERS
@joshmoore joshmoore mentioned this issue Sep 23, 2021
Closed
@jakirkham jakirkham mentioned this issue Nov 22, 2022
Closed
@jakirkham jakirkham mentioned this issue Mar 8, 2023
Closed
7 tasks
@jhamman
Copy link
Member

jhamman commented Oct 17, 2024

I think the developments in the v3 stream of work warrant closing this.

@jhamman jhamman closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@joshmoore @rabernat @jhamman @jakirkham @martindurant @shikharsg