-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup builds #91
Cleanup builds #91
Conversation
After the extraction of the napari plugin to `napari-ome-zarr`, a number of the matrix builds can be eliminated. This PR attempts to drop any dependencies on Qt-related code which should all be in the plugin repository.
@will-moore : in order to get rid of the vispy dependency, can you see just adding these values raw rather than wrapping them with a
|
A It looks like |
So store |
I would think that |
de2da97
to
d79c393
Compare
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 67.18% 69.37% +2.18%
==========================================
Files 10 11 +1
Lines 963 1035 +72
==========================================
+ Hits 647 718 +71
- Misses 316 317 +1
Continue to review full report at Codecov.
|
Failure is caused by the recently merged zarr-developers/zarr-python#781 Edit: fixed zarr's mainline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshmoore this looks good. Could we merge this now and then merge main into #89 in order to simplify the tests?
Yeah, let's do that. Then we can build up our confidence in this a bit more in this PR before cutting a release. |
After the extraction of the napari plugin to
napari-ome-zarr
,a number of the matrix builds can be eliminated. This PR attempts
to drop any dependencies on Qt-related code which should all be in
the plugin repository.