-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release[docs]: add release notes for v0.4.1 ("Tokara Habu") #4310
release[docs]: add release notes for v0.4.1 ("Tokara Habu") #4310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4310 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 120 120
Lines 17343 17343
Branches 2937 2937
=======================================
Hits 15968 15968
Misses 957 957
Partials 418 418 ☔ View full report in Codecov by Sentry. |
1a92b67
to
2c38950
Compare
d44dcdd
to
d986fa1
Compare
docs/release-notes.rst
Outdated
* fix[ux]: fix false positive for overflow in type checker (`#4385 <https://github.com/vyperlang/vyper/pull/4385>`_) | ||
* fix[ux]: add missing filename to syntax exceptions (`#4343 <https://github.com/vyperlang/vyper/pull/4343>`_) | ||
* fix[lang]: disallow absolute relative imports (`#4268 <https://github.com/vyperlang/vyper/pull/4268>`_) | ||
* fix[stdlib]: fix ``IERC4626`` signatures (`#4425 <https://github.com/vyperlang/vyper/pull/4425>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* fix[stdlib]: fix ``IERC4626`` signatures (`#4425 <https://github.com/vyperlang/vyper/pull/4425>`_) | |
* fix[stdlib]!: fix ``IERC4626`` signatures (`#4425 <https://github.com/vyperlang/vyper/pull/4425>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned here that this is missing fwiw #4425 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, it's missing the !
in the commit log. i guess it's not a huge deal to differ a bit from the commit log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
Co-authored-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
==========================================
██╗░░░██╗██╗░░░██╗██████╗░███████╗██████╗░
██║░░░██║╚██╗░██╔╝██╔══██╗██╔════╝██╔══██╗
╚██╗░██╔╝░╚████╔╝░██████╔╝█████╗░░██████╔╝
░╚████╔╝░░░╚██╔╝░░██╔═══╝░██╔══╝░░██╔══██╗
░░╚██╔╝░░░░░██║░░░██║░░░░░███████╗██║░░██║
░░░╚═╝░░░░░░╚═╝░░░╚═╝░░░░░╚══════╝╚═╝░░╚═╝
==========================================
* fix[codegen]: fix ``abi_encode`` buffer size in external calls (`#4202 <https://github.com/vyperlang/vyper/pull/4202>`_) | ||
* fix[lang]: fix ``==`` and ``!=`` bytesM folding (`#4254 <https://github.com/vyperlang/vyper/pull/4254>`_) | ||
* fix[lang]: fix ``.vyi`` function body check (`#4177 <https://github.com/vyperlang/vyper/pull/4177>`_) | ||
* fix[venom]: invalid jump error (`#4214 <https://github.com/vyperlang/vyper/pull/4214>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other venom fixes are in the venom section
docs/release-notes.rst
Outdated
* fix[ux]: fix validation for ``abi_encode()`` ``method_id`` kwarg (`#4369 <https://github.com/vyperlang/vyper/pull/4369>`_) | ||
* fix[ux]: fix false positive for overflow in type checker (`#4385 <https://github.com/vyperlang/vyper/pull/4385>`_) | ||
* fix[ux]: add missing filename to syntax exceptions (`#4343 <https://github.com/vyperlang/vyper/pull/4343>`_) | ||
* fix[lang]: disallow absolute relative imports (`#4268 <https://github.com/vyperlang/vyper/pull/4268>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe mention this in breaking? like this design was originally intended. i think that even snekmate used this pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think that even snekmate used this pattern?
correct: fixed here pcaversaccio/snekmate@396c880#diff-dbed5d29c7e1efc38bb3ee7dd46526b7ab6731a17dffe12c00cf5494a7c36ff6
another breaking one for snekmate was the removal of return
statement in .vyi
interfaces: pcaversaccio/snekmate#261
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* fix[venom]: invalid jump error (`#4214 <https://github.com/vyperlang/vyper/pull/4214>`_) | ||
* fix[lang]: fix precedence in floordiv hint (`#4203 <https://github.com/vyperlang/vyper/pull/4203>`_) | ||
* fix[lang]: define rounding mode for sqrt (`#4486 <https://github.com/vyperlang/vyper/pull/4486>`_) | ||
* fix[codegen]: disable augassign with overlap (`#4487 <https://github.com/vyperlang/vyper/pull/4487>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also breaking
This reverts commit 5f1aeb5.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture