Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[tool]: roll back OS used to build binaries #4494

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 24, 2025

What I did

fix over-aggressive upgrade from #4473

How I did it

How to verify it

Commit message

per ae6ab0d3dc58167cc6, the OS image used to build vyper binaries was
updated. however, this can break users who don't have a compatible libc
(i.e., at least as recent as the latest ubuntu). roll back to an older
ubuntu for those users.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

per ae6ab0d, the OS image used to build vyper binaries was
updated. however, this can break users who don't have a compatible libc
(i.e., at least as recent as the latest ubuntu). roll back to an older
ubuntu for those users.
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (dd5a3d9) to head (6bd8ebd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4494   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         120      120           
  Lines       17335    17335           
  Branches     2935     2935           
=======================================
  Hits        15960    15960           
  Misses        957      957           
  Partials      418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 1339177 into vyperlang:master Feb 25, 2025
163 checks passed
@charles-cooper charles-cooper deleted the fix/ci/rollback-ubuntu-image branch February 25, 2025 13:31
charles-cooper added a commit to charles-cooper/vyper that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants