fix[stdlib]: fix IERC4626 signatures
#4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the signatures should not have default parameters; if used, they will create a different method id at the callsite than the `ERC4626` standard actually accepts.
charles-cooper
changed the title
IERC4626 signaturesIERC4626 signatures
fubuloubu
approved these changes
Dec 27, 2024
cyberthirst
approved these changes
Dec 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4425 +/- ##
==========================================
- Coverage 91.78% 90.93% -0.85%
==========================================
Files 119 119
Lines 16631 16631
Branches 2799 2799
==========================================
- Hits 15265 15124 -141
- Misses 936 1050 +114
- Partials 430 457 +27 ☔ View full report in Codecov by Sentry. |
|
Since this is a breaking fix, we should use the exclamation mark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture