-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add simulation tests #98
test: add simulation tests #98
Conversation
* master: fix: solve module, sdk issues test: improve code coverage test: add cli integration tests test: add integration cli test for ratio plan, stake, and unstake refactor: update description and use string slice flag for harvest for better developer experience feat: add integration test for create fixed amount plan command-line interface
…ctor, add workflow
…64-simulation-test * commit '6dea151437ce42ffd0b68c5486fa210195ce6696': feat: add genesis functionality (tendermint#87)
… work in progress to solve harvest issue
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 55.38% 64.64% +9.26%
==========================================
Files 23 24 +1
Lines 1728 2062 +334
==========================================
+ Hits 957 1333 +376
+ Misses 662 598 -64
- Partials 109 131 +22
Continue to review full report at Codecov.
|
- add request public plan proposal - update request public plan proposal - delete request public plan proposal - comment TODO to improve public plans logic
Running |
* master: docs: update README.md build: bump sdk to v0.44.0
# Conflicts: # x/farming/keeper/genesis.go # x/farming/simulation/decoder.go # x/farming/types/genesis.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on simulation part. As you have stated offline, let's tackle this with other PR(s) since this PR is becoming huge.
Description
This PR is contiunation of #83 that include simulation tests for both public and private plans.
closes: #64 #88
Actions
Further improvements
We need to come up with better ways to simulate public plan proposals. Currently, only basic logics are written.
And after genesis functionality with F1 logic is implemented, we plan to add below simulations
runsim
to test import and export simulationrunsim
to test simulation after importBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes