feat: add genesis functionality #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 56.28% 56.88% +0.59%
==========================================
Files 24 24
Lines 1766 1830 +64
==========================================
+ Hits 994 1041 +47
- Misses 670 682 +12
- Partials 102 107 +5
Continue to review full report at Codecov.
|
|
|
||
| return types.NewGenesisState(params, planRecords, nil, nil) | ||
| epochTime, _ := k.GetLastEpochTime(ctx) |
There was a problem hiding this comment.
LastEpochTime may be not present on the store so the second return value found can be false. In that case, calling NewGenesisState with concrete time.Time value will not act as expected.
There was a problem hiding this comment.
That's right. If there's no value(false), the expectation is to return time.Time{} and set it to this empty time.Time{} value for export genesis. Can't we do this?
…64-simulation-test * commit '6dea151437ce42ffd0b68c5486fa210195ce6696': feat: add genesis functionality (tendermint#87)
Description
closes: #66
Bullet Points
References
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes