Add check for duplicate name value when creating private plans

[jaybxyz]

Summary of Bug

There is no check for duplicate name value when creating private plans. This bug is found during simulation test.

Version

master branch

Steps to Reproduce

1. Send MsgCreateFixedAmountPlan transaction to the network with the plan name simulation.
2. Send MsgCreateRatioPlan transaction to the network with the same plan name simulation.
3. Send PublicPlanProposal to the network with any plan name.
4. You will encounter an error: duplicate plan name: invalid proposal content

Proposal

ValidateRatioPlans checks duplicate name value; however, we can't use the function for private plans since private plans have two different messages to handle and the function handles total epoch ratio and name checks. Therefore, I suggest to have the function broken down into two different functions; ValidateTotalEpochRatio and ValidateName.

farming/x/farming/keeper/proposal_handler.go

Lines 30 to 33 in 72748af

	plans := k.GetAllPlans(ctx)
	if err := types.ValidateRatioPlans(plans); err != nil {
	return err
	}

farming/x/farming/types/plan.go

Lines 254 to 291 in 72748af

	func ValidateRatioPlans(i interface{}) error {
	plans, ok := i.([]PlanI)
	if !ok {
	return sdkerrors.Wrapf(ErrInvalidPlanType, "invalid plan type %T", i)
	}
	totalEpochRatio := make(map[string]sdk.Dec)
	names := make(map[string]bool)
	for _, plan := range plans {
	farmingPoolAddr := plan.GetFarmingPoolAddress().String()
	if plan, ok := plan.(*RatioPlan); ok {
	if err := plan.Validate(); err != nil {
	return err
	}
	if epochRatio, ok := totalEpochRatio[farmingPoolAddr]; ok {
	totalEpochRatio[farmingPoolAddr] = epochRatio.Add(plan.EpochRatio)
	} else {
	totalEpochRatio[farmingPoolAddr] = plan.EpochRatio
	}
	if _, ok := names[plan.Name]; ok {
	return sdkerrors.Wrap(ErrDuplicatePlanName, plan.Name)
	}
	names[plan.Name] = true
	}
	}
	for _, farmerRatio := range totalEpochRatio {
	if farmerRatio.GT(sdk.NewDec(1)) {
	return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "total epoch ratio must be lower than 1")
	}
	}
	return nil
	}

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned