Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @JsonUnwrapped does not copy required properties: Resolves #3879 #3880

Merged
merged 3 commits into from
Apr 18, 2021

Conversation

twobiers
Copy link
Contributor

Fix @JsonUnwrapped does not copy required properties:

#3879

Let me know if you want some changes.

Fix @JsonUnwrapped does not copy required properties
@twobiers twobiers changed the title Resolves #3879 Fix @JsonUnwrapped does not copy required properties: Resolves #3879 Feb 12, 2021
@dtanzer
Copy link

dtanzer commented Apr 3, 2021

I ran into this bug too, would need a solution.

Also @tobi6112 , how did you solve it locally? by building swagger-core from source with your fix? Or do you have a workaround for spring boot?

@twobiers
Copy link
Contributor Author

twobiers commented Apr 3, 2021

@dtanzer yes I built it locally by running mvn install. This will install swagger-core into your local maven repository. Then springdoc in my case will use the local dependency.

@frantuma frantuma merged commit 56d233b into swagger-api:master Apr 18, 2021
@frantuma
Copy link
Member

@tobi6112 Thanks!

@ondrejkrpec
Copy link

This is not fixed properly yet. If the @JsonUnwrapped annotation contains a prefix or a suffix then the property is not added to the required list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants