Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@JsonUnwrapped required properties will not be copied #3879

Closed
twobiers opened this issue Feb 12, 2021 · 1 comment
Closed

@JsonUnwrapped required properties will not be copied #3879

twobiers opened this issue Feb 12, 2021 · 1 comment

Comments

@twobiers
Copy link
Contributor

See: springdoc/springdoc-openapi#1060

When a Type is annotated with @JsonUnwrapped and the unwrapped class does have required properties they won't be mapped to the unwrapping Schema.

I've already resolved the issue and created a PR
twobiers added a commit to twobiers/swagger-core that referenced this issue Feb 12, 2021
@twobiers
Resolves swagger-api#3879
9e1ac33 
Fix @JsonUnwrapped does not copy required properties
@twobiers twobiers changed the title @JsonUnwrapped required properties will not be @JsonUnwrapped required properties will not be copied Feb 12, 2021
@twobiers twobiers mentioned this issue Feb 12, 2021
Merged
@twobiers
Copy link
Contributor Author

twobiers commented Feb 25, 2021 •
edited
Loading

Just noticed that this is a duplicate to: #3683

@frantuma frantuma mentioned this issue Apr 18, 2021
Closed
@ondrejkrpec ondrejkrpec mentioned this issue Jun 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twobiers