New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSR-303 annotations ignored with @JsonUnwrapped #3683

Closed

miloszszyrner opened this issue Aug 22, 2020 · 1 comment

miloszszyrner commented Aug 22, 2020

I have reported an issue where I was redirected to post it here
Working with Spring Doc version 1.4.4 found issue with @JsonUnwrapped

Code to reproduce

@Getter
@Setter
@AllArgsConstructor
@NoArgsConstructor
@Builder
public class Base

@NotBlank
private String id;

@Valid
@JsonUnwrapped
private UnwrappedObject unwrappedObject


@Getter
@Setter
@Builder
@NoArgsConstructor
@AllArgsConstructor
public class UnwrappedObject 

@Schema(required = true)
@NotBlank(message = "Property cannot be blank")
private String property;

In generate documentation, id is marked as required whereas property is not

bnasslahsen mentioned this issue

Schema with @JsonUnwrapped does not include required properties springdoc/springdoc-openapi#1060

Closed

twobiers mentioned this issue

@JsonUnwrapped required properties will not be copied #3879

Closed

Member

frantuma commented Apr 18, 2021

see also #3879, fixed in #3880

frantuma closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment