Skip to content

Commit

Permalink
Add note about required-ros-distributions caveat on Ubuntu (#464)
Browse files Browse the repository at this point in the history
* Add note about required-ros-distributions caveat on Ubuntu

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
  • Loading branch information
christophebedard authored Feb 25, 2022
1 parent 824b6c5 commit 44272f4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ build_docker:
- run: "source /opt/ros/noetic/setup.bash && rosnode --help"
```

**Note: on Ubuntu, `required-ros-distributions` installs the desktop variant for that distribution. This option is not required, and should probably be avoided in most workflows. It is retained for historical reasons and those who specifically do not care about whether their application specifies its dependencies properly.**

### Use pre-release ROS 2 binaries for testing

You can specify if you'd like to use the [pre-release ROS 2 repository][pre_release_testing] in your sources list file by setting the `use-ros2-testing` parameter to `true`.
Expand Down
7 changes: 3 additions & 4 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ inputs:
description: |
List of binary ROS distributions to be installed.
Support for non-Linux platform is not implemented yet, so this
parameter is ignored on Mac OS X and Windows.
On Ubuntu, this installs the desktop variant for the given distribution.
On Windows, this downloads and extracts the binaries for the given distribution.
This parameter is ignored on macOS.
Allowed ROS distributions
- "" (no value) - no ROS binary installation
Expand All @@ -36,8 +37,6 @@ inputs:
Multiple values can be passed using a whitespace delimited list
"melodic dashing".
For each passed ROS distribution, its desktop variant will be installed.
required: false
default: ""
runs:
Expand Down

0 comments on commit 44272f4

Please sign in to comment.