Lint: Fix [602] Don't compare to empty string
#1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
reviewed
Jan 19, 2020
| @@ -7,9 +7,9 @@ | |||
| no_log: true | |||
| changed_when: false | |||
| when: | |||
| - composer_authentication.hostname is defined and composer_authentication.hostname != "" | |||
There was a problem hiding this comment.
Do we even need to check these? Seems pretty defensive. By default they just aren't defined right? So this is only guarding against people defining them with no value?
There was a problem hiding this comment.
We need it (at least the password one) because of password defaults to empty string. See:
trellis/group_vars/all/helpers.yml
Lines 23 to 26 in faaf213
I suggest we remove all 3 when conditions when we depercate packagist_token
swalkinshaw
approved these changes
Jan 19, 2020
tangrufus
added a commit
to tangrufus/trellis
that referenced
this pull request
Jan 22, 2020
roots#1141 bases on ansible/ansible-lint#457 (comment) which depends on ansible/ansible#51030 which merged into anisble v2.8.0.
swalkinshaw
pushed a commit
that referenced
this pull request
Apr 4, 2020
#1141 bases on ansible/ansible-lint#457 (comment) which depends on ansible/ansible#51030 which merged into anisble v2.8.0.
swalkinshaw
pushed a commit
that referenced
this pull request
Apr 6, 2020
#1141 bases on ansible/ansible-lint#457 (comment) which depends on ansible/ansible#51030 which merged into anisble v2.8.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ansible/ansible-lint#457 (comment)