Lint: Fix [602] Don't compare to empty string (#1141)

Lint: Fix `[602] Don't compare to empty string`
roots · Jan 19, 2020 · ab70d8e · ab70d8e
2 parents 0e0a6a1 + 34689c2
commit ab70d8e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/roles/connection/tasks/main.yml b/roles/connection/tasks/main.yml
@@ -12,7 +12,7 @@
   register: preferred_host_key_algorithms
   when:
     - dynamic_host_key_algorithms | default(true)
-    - ansible_ssh_extra_args | default('') == ''
+    - not (not ansible_ssh_extra_args)
     - not (ansible_host_known or ssh_config_host_known)
 
 - name: Check whether Ansible can connect as {{ dynamic_user | default(true) | ternary('root', web_user) }}

diff --git a/roles/wordpress-install/tasks/composer-authentications.yml b/roles/wordpress-install/tasks/composer-authentications.yml
@@ -7,9 +7,9 @@
   no_log: true
   changed_when: false
   when:
-    - composer_authentication.hostname is defined and composer_authentication.hostname != ""
-    - composer_authentication.username is defined and composer_authentication.username != ""
-    - composer_authentication.password is defined and composer_authentication.password != ""
+    - not (not composer_authentication.hostname)
+    - not (not composer_authentication.username)
+    - not (not composer_authentication.password)
   loop: "{{ composer_authentications }}"
   loop_control:
     loop_var: composer_authentication