Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ansible requirement to 2.8.0 #1166

Merged
merged 3 commits into from
Apr 6, 2020
Merged

Bump ansible requirement to 2.8.0 #1166

merged 3 commits into from
Apr 6, 2020

Conversation

swalkinshaw
Copy link
Member

No description provided.

@swalkinshaw swalkinshaw requested a review from tangrufus April 4, 2020 21:23
@swalkinshaw swalkinshaw mentioned this pull request Apr 4, 2020
Closed
tangrufus
tangrufus approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@tangrufus tangrufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 awesome!

tangrufus
tangrufus requested changes Apr 6, 2020
View reviewed changes
Copy link
Member

@tangrufus tangrufus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop ansible 2.7 tests from CircleCI

See: #1172

@swalkinshaw swalkinshaw force-pushed the TangRufus-fix-lint-602 branch from b38bed6 to 980b142 Compare April 6, 2020 13:24
@swalkinshaw
Copy link
Member Author

@tangrufus one thing that confused me... your original PR said 2.8 was required for another PR that was already merged. Does it >=2.7.12 <2.8 had actually been broken already?

@tangrufus
Copy link
Member

tangrufus commented Apr 6, 2020 •
edited
Loading

Does it >=2.7.12 <2.8 had actually been broken already?

Yes. Trellis is broken on ansible 2.7.x since #1141

The not not hack requires ansible >=2.8.0

https://discourse.roots.io/t/provisioning-server-not-working-because-ansible-ssh-extra-args-is-undefined/17484

@swalkinshaw swalkinshaw merged commit 5077c3d into master Apr 6, 2020
@swalkinshaw swalkinshaw deleted the TangRufus-fix-lint-602 branch April 6, 2020 14:14
@swalkinshaw swalkinshaw mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangrufus tangrufus tangrufus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swalkinshaw @tangrufus