Move selection panel UI to new re_selection_panel crate
#6431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
🚜 refactor
|
deps graphs via 0.16: now: |
abey79
force-pushed
the
antoine/re-blueprint_tree
branch
from
1eecd45 to
1a07cc4
Compare
abey79
force-pushed
the
antoine/re-selection-panel
branch
from
7d70f5d to
12fb2a1
Compare
Wumpf
approved these changes
May 27, 2024
abey79
force-pushed
the
antoine/re-selection-panel
branch
from
12fb2a1 to
adbc477
Compare
|
On this branch: 2m 29s slower unfortunately but this might be within the margin of error |
abey79
added a commit
that referenced
this pull request
May 28, 2024
### What - Make the `render_context` field of `ViewerContext` an `Option` to make it easier to crate a `ViewerContext` in a test environment. - Introduce a (very basic) test helper that creates a `ViewerContext` for use in unit test. - Demo unit test that attempts to run `SelectionPanel::show_panel()` Chained to #6431 There are many improvements that could be added: - similar support for `ViewportBlueprint` - make `re_log::warn/err` assert: #6450 - add support for easily populating the stores with data - benchmarking support? - etc. etc. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6432?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6432?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6432) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
☝🏻
Chained to #6427
I made the following calls (along with @Wumpf):
SpaceViewStatestore_view_context(along with the space view class stuff).Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.