Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a new leaf crate to the viewer crate ecosystem.
While working on edit/data uis I noticed that most of the things in this crate just register ui and aren't used anywhere else. Unfortunately,
re_data_ui
provides various non component ui (causing it to become a more basic crate) and the orphan rule makes it fairly hard to move things out. So far however, edit uis have been untained by this! I want this to stay this way since:re_viewer
itself stay wideAs we provide more and more edit ui we might end up where we prefer edit ui over display ui when available (using a disabled edit ui) which means that over time
re_edit_ui
will be more important. Having it be only a dependency ofre_reviewer
ensures a clean architecture.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.