Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make re_edit_ui its own crate #6444

Merged
merged 4 commits into from
May 28, 2024
Merged

Make re_edit_ui its own crate #6444

merged 4 commits into from
May 28, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 28, 2024

What

Adds a new leaf crate to the viewer crate ecosystem.
While working on edit/data uis I noticed that most of the things in this crate just register ui and aren't used anywhere else. Unfortunately, re_data_ui provides various non component ui (causing it to become a more basic crate) and the orphan rule makes it fairly hard to move things out. So far however, edit uis have been untained by this! I want this to stay this way since:

  • changing edit ui is a frequent operation
  • this is an easy opportunity to have crate compilation up to re_viewer itself stay wide

As we provide more and more edit ui we might end up where we prefer edit ui over display ui when available (using a disabled edit ui) which means that over time re_edit_ui will be more important. Having it be only a dependency of re_reviewer ensures a clean architecture.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 28, 2024
@Wumpf Wumpf force-pushed the andreas/split-out-edit-ui branch from cd7de9f to 0bd4b27 Compare May 28, 2024 08:29
@emilk
Copy link
Member

emilk commented May 28, 2024

I'm curious about what

cargo install cargo-depgraph
cargo depgraph --all-deps --workspace-only --all-features --dedup-transitive-deps | dot -Tpng > deps.png
open deps.png

looks like these days

@Wumpf
Copy link
Member Author

Wumpf commented May 28, 2024

@emilk I did a before after here recently
#6431 (comment)

As expected, this adds another direct dependency to re_viewer:
image
(unfortunately doesn't place it nicely though)

Again, 0.16:
333894701-98b6cec1-d85e-406a-9224-da88fc63e244

@Wumpf Wumpf merged commit 5561df4 into main May 28, 2024
34 checks passed
@Wumpf Wumpf deleted the andreas/split-out-edit-ui branch May 28, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants