Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to display multiple tensors in a single space view #6392

Merged
merged 7 commits into from
May 23, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented May 21, 2024

What

Configuring a tensor space view with a query returning more than 1 tensor is now displayed as follows:

image

This is consistent with the existing behaviour of TextDocument:

image

This PR is very minimal and aims at status quo consistency. This could be further improved:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog labels May 21, 2024
@abey79 abey79 marked this pull request as draft May 21, 2024 16:55
@abey79 abey79 marked this pull request as ready for review May 21, 2024 17:35
@abey79 abey79 merged commit be6d679 into main May 23, 2024
35 checks passed
@abey79 abey79 deleted the antoine/remove-multi-tensor branch May 23, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the ability to display multiple tensors in the same space view
2 participants