Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the UI of "mono-entity" space views #6393

Open
abey79 opened this issue May 21, 2024 · 0 comments
Open

Improve the UI of "mono-entity" space views #6393

abey79 opened this issue May 21, 2024 · 0 comments
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented May 21, 2024

Some space views (TextDocument, Tensor since #6392) can only display a single entity, and error in case more than one (of the correct type) is returned by the query:

image

This UI could be improved:

  • The error message in the space view could offer a button to split into N space views, each containing on of the entities.
  • Warnings are sometime displayed next to the query editor, e.g. when no entities are matched. It would be nice if the "too many entities" warning was displayed in the same way. (That would probably require the space view class to have a "mono-entity" setting.)
image
@abey79 abey79 added the ui concerns graphical user interface label May 21, 2024
@abey79 abey79 mentioned this issue May 21, 2024
Merged
5 tasks
abey79 added a commit that referenced this issue May 23, 2024
@abey79
Remove the ability to display multiple tensors in a single space view (…
be6d679 
…#6392)

### What

- Fixes #6387

Configuring a tensor space view with a query returning more than 1
tensor is now displayed as follows:

<img width="435" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/dc4182f1-ab0e-4ec2-96cb-9891a02164c6">
<br/><br/>

This is consistent with the existing behaviour of TextDocument:

<img width="459" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/f73e6c2d-29f3-4046-9d9e-a5789c93a6cd">
<br/><br/>

This PR is very minimal and aims at status quo consistency. This could
be further improved:
- #6393



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6392?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6392?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6392)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abey79