Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to display multiple tensors in the same space view #6387

Closed
abey79 opened this issue May 20, 2024 · 0 comments · Fixed by #6392
Closed

Remove the ability to display multiple tensors in the same space view #6387

abey79 opened this issue May 20, 2024 · 0 comments · Fixed by #6392
Labels
📺 re_viewer affects re_viewer itself
Milestone
0.17

Comments

@abey79
Copy link
Member

abey79 commented May 20, 2024

The tensor space view has the rarely used ability to display multiple tensors using a (glitchy: #6385) tab widget made of radio buttons. This features probably comes from a time where tabbed space views didn't even exist, and incurs complexity and inconsistency:

  • The space view property are current "per tensor", which makes them very hard to blueprint-ify.
  • The UI for what should be space-view-specific property is actually dependent on the "current" tensor.

Given that multi-tensor views are hardly ever used and easy to emulate with multiple views, this feature should be removed.

In case the query yields more than 1 tensor, the tensor view should:

  • display a warning in the view itself
  • display a warning the selection panel
  • (side quest) somehow show the un-displayable tensors in the blueprint tree?
@abey79 abey79 added the 📺 re_viewer affects re_viewer itself label May 20, 2024
@abey79 abey79 added this to the 0.17 milestone May 20, 2024
This was referenced May 20, 2024
Closed
Merged
abey79 added a commit that referenced this issue May 23, 2024
@abey79
Remove the ability to display multiple tensors in a single space view (…
be6d679 
…#6392)

### What

- Fixes #6387

Configuring a tensor space view with a query returning more than 1
tensor is now displayed as follows:

<img width="435" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/dc4182f1-ab0e-4ec2-96cb-9891a02164c6">
<br/><br/>

This is consistent with the existing behaviour of TextDocument:

<img width="459" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/f73e6c2d-29f3-4046-9d9e-a5789c93a6cd">
<br/><br/>

This PR is very minimal and aims at status quo consistency. This could
be further improved:
- #6393



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6392?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6392?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6392)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.17
Development

Successfully merging a pull request may close this issue.

Remove the ability to display multiple tensors in a single space view rerun-io/rerun
1 participant
@abey79