Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] FIXED - appended payment code to ID field to make it unique #1

Open
wants to merge 987 commits into
base: 2.3-develop
Choose a base branch
from
Open

[Forwardport] FIXED - appended payment code to ID field to make it unique #1

wants to merge 987 commits into from

Conversation

rakesh-gangani
Copy link
Owner

Original Pull Request

magento#15344

Description

Fixed Issues (if relevant)

  1. In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method magento/magento2#13692: In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method

Manual testing scenarios

  1. Log in to your client account.
  2. Add product to cart.
  3. Go to checkout and click next button to be able to choose payment methods.
  4. Open payment method other than the first one.
  5. Uncheck My billing and shipping address are the same checkbox
  6. Choose New address on the billing address dropdown
  7. Fill address
  8. Click on label Save in address book

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

zakdma and others added 30 commits June 5, 2018 12:10
@zakdma
Merge remote-tracking branch 'origin/MAGETWO-66217' into 2.3-develop-…
78e0d13 
…pr21
@zakdma
Merge remote-tracking branch 'origin/MAGETWO-90349' into 2.3-develop-…
745d99d 
…pr21
@zakdma
Merge remote-tracking branch 'origin/MAGETWO-64173' into 2.3-develop-…
71bfdc6 
…pr21
@magento-engcom-team
ENGCOM-1689: fix for Wrong price amount on product page magento#11717 m…
843fa11 
…agento#15540

 - Merge Pull Request magento#15540 from Veriteworks/magento2:fixPriceFormat
 - Merged commits:
   1. cf05a84
   2. 67a2038
@yogeshsuhagiya @chirag-wagento
Format the javascript code
110ee75
@yogeshsuhagiya @chirag-wagento
Refactor JS code and added JS component file
3994790
@yogeshsuhagiya @chirag-wagento
Fixed issue of line feed at end of the file
8281b38
@OlgaVasyltsun
Merge remote-tracking branch 'origin/MAGETWO-50831' into 2.3-develop-…
d008516 
…pr22
@magento-engcom-team
ENGCOM-1871: [Forwardport] Format the javascript code magento#10 mage…
e7dc28f 
…nto#15833

 - Merge Pull Request magento#15833 from chirag-wagento/magento2:2.3-develop-PR-port-14967
 - Merged commits:
   1. 110ee75
   2. 3994790
   3. 8281b38
@torhoehn
check if order data is available to incl ec
e46e5a5
@magento-engcom-team
ENGCOM-1872: [Up-port] check if order data is available to incl ec ma…
c77d3cb 
…gento#15847

 - Merge Pull Request magento#15847 from torhoehn/magento2:up-port-pull-15765
 - Merged commits:
   1. e46e5a5
@svitja
MAGETWO-67024: Sorting by price ignores Catalog Price Rule for Simple…
c3f5cd7 
… product with required custom option
@svitja
MAGETWO-67024: Sorting by price ignores Catalog Price Rule for Simple…
c5295a4 
… product with required custom option
@magento-engcom-team
ENGCOM-1873: Fixed a couple of typos magento#15695
4bb4155 
 - Merge Pull Request magento#15695 from dverkade/magento2:2.3-Fix-typos
 - Merged commits:
   1. f0eb540
@OlgaVasyltsun
MAGETWO-90764: [2.3.0] Cannot cancel orders with an expired authoriza…
8583f10 
…tion for Braintree
@dthampy
MAGETWO-91434: Default option for Status attribute not being set
644aabc 
- addressed CR comments
@jilu1
MC-141: Guest customer should be able to advance search grouped produ…
7094961 
…ct with product name

MC-146: Guest customer should be able to advance search grouped product with product sku
MC-282: Guest customer should be able to advance search grouped product with product description
MC-283: Guest customer should be able to advance search grouped product with product short description
MC-284: Guest customer should be able to advance search grouped product with product price

- added mftf tests
@rogyar
Fixed return type hinting in DocBlocks
ea8c241
@danielrenaud
Merge remote-tracking branch 'mainline/2.3-develop' into MAGETWO-9184…
16dd29a 
…8-max-characters
merge magento/2.3-develop into magento-arcticfoxes/MAGETWO-91434
addd4af
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
d3c682e 
- swatches fix
@magento-engcom-team
ENGCOM-1877: Fixed return type hinting in DocBlocks for Wishlist module
539039c 
magento#15853

 - Merge Pull Request magento#15853 from rogyar/magento2:2.3-wishlist-return-fix
 - Merged commits:
   1. ea8c241
merge magento/2.3-develop into magento-honey-badgers/MAGETWO-91436-Cu…
5aaf95b 
…stom-Options-are-corruputed
@mhaack @dmytro-ch
Update webapi.xml to fix typo
43533f9
@eric-bohanon
MAGETWO-91437: Invalidate indexer after category is deleted
2c9cc60 
 - Write plugin to invalidate fulltext
 - Invalidate category_product on after delete for Category resource model
 - Write integration tests
@eric-bohanon
MAGETWO-91437: Fix tests
eeef0be
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
8d275f7 
- swatches test
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
89052b6 
- swatches test
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
f3d5e73 
- swatches test
@leviv
MC-181: Configurable Product goes "Out of Stock" if all associated Si…
ef2c079 
…mple Products are "Out of Stock"
Stanislav Idolov and others added 30 commits June 12, 2018 17:11
ENGCOM-1882: [Forwardport] [Resolved : limiter float too generic] mag…
f238b8d 
…ento#15879
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
8313fc3 
- builds stabilization
@rganin
Merge branch '2.3-develop' of github.com:magento/magento2ce into MAGE…
025d23c 
…TWO-91570
@rganin
Merge branch 'MAGETWO-91570' of github.com:magento-earl-grey/magento2…
9cf29a6 
…ce into MAGETWO-91570
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
aa9f0f0 
- builds stabilization
merge magento/2.3-develop into magento-borg/MAGETWO-91529
b15327b
ENGCOM-1904: [Forwardport] [Resolved : Changing @tab-content__border …
32486c5 
…variable has no effect in B… magento#15916
@tomreece
Merge remote-tracking branch 'origin/2.3-develop' into RE-develop
85953af
@cpartica
Merge pull request magento#2691 from magento-borg/MAGETWO-91529
eca9d9d 
[borg] MAGETWO-91529: Restricted admin user can remove product from other websites
@magento-engcom-team
[EngCom] Public Pull Requests - 2.3-develop
f57a4ef 
 - merged latest code from mainline branch
merge magento/2.3-develop into magento-pangolin/RE-develop
1a1e5bf
Fixed static test failures
8132ea4
Fixed static test failures
5d5bd7a
@zakdma
Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop-pr23
5bb066c
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
285a39c 
Accepted Public Pull Requests:
 - magento#16042: [Forwardport] fix for dropdown toggle icon in cart (by @chirag-wagento)
 - magento#16045: [Forwardport] Extend default config instead overwrite (by @chirag-wagento)
 - magento#16022: Wishlist: Remove unnecessary parameter from invoking toHtml() method (by @rogyar)
 - magento#15916: [Forwardport] [Resolved : Changing @tab-content__border variable has no effect in B� (by @hitesh-wagento)
 - magento#15884: [Forwardport 2.3] Trim username on customer account login page (by @dankhrapiyush)
 - magento#15896: [Forwardport] Solve overlapping Issue on every Home page & category page of Hot Sel (by @chirag-wagento)
 - magento#15879: [Forwardport] [Resolved : limiter float too generic] (by @hitesh-wagento)


Fixed GitHub Issues:
 - magento#14999: Changing @tab-content__border variable has no effect in Blank theme (reported by @denistrator) has been fixed in magento#15916 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 21ce9fb

 - magento#6058: IE11 user login email validation fails if field has leading or trailing space (reported by @dnadle) has been fixed in magento#15884 by @dankhrapiyush in 2.3-develop branch
   Related commits:
     1. c44f1f8

 - magento#15213: Alignment & overlapping Issue on every Home page & category page of Hot Seller section (reported by @cnviradiya) has been fixed in magento#15896 by @chirag-wagento in 2.3-develop branch
   Related commits:
     1. a851540

 - magento#15323: limiter float too generic (reported by @DanielRuf) has been fixed in magento#15879 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 172e5ae
merge magento/2.3-develop into magento-tsg/2.3-develop-pr23
012d0a3
Merge pull request magento#2696 from magento-tsg/2.3-develop-pr23
c67893b 
[TSG] Upporting for 2.3 (pr23) (2.3.0)
merge magento/2.3-develop into magento-earl-grey/MAGETWO-91570
983370f
@tomreece
MQE-1061: Stabilize RE-develop branch
03011d0
merge magento/2.3-develop into magento-pangolin/RE-develop
6216112
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
13927e3 
- fixed default attribute setting
@rganin
Merge branch 'MAGETWO-91570' of github.com:magento-earl-grey/magento2…
e3a04cb 
…ce into MAGETWO-91570
@okolesnyk
Merge pull request magento#2683 from magento-pangolin/RE-develop
919dd8c 
[pangolin] RE-develop functional tests
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
d3e8f82 
- test fix
merge magento/2.3-develop into magento-earl-grey/MAGETWO-91570
05e5df7
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
2328833 
- test fix
@rganin
Merge branch 'MAGETWO-91570' of github.com:magento-earl-grey/magento2…
019cf68 
…ce into MAGETWO-91570
@rganin
MAGETWO-91570: [2.2.x] - [Github]Can not save attribute magento#5907
1a22d95 
- test fix
@cpartica
Merge pull request magento#2673 from magento-earl-grey/MAGETWO-91570
f8b3385 
[earl] MAGETWO-90803 & MAGETWO-91570
@rakesh-gangani
FIXED - appended payment code to ID field to make it unique
f971e15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.