Refactor JS code and added JS component file

rakesh-gangani · Jun 5, 2018 · 3994790 · 3994790
1 parent 110ee75
commit 3994790
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 10 deletions.
diff --git a/app/code/Magento/Ui/view/base/templates/control/button/split.phtml b/app/code/Magento/Ui/view/base/templates/control/button/split.phtml
@@ -17,7 +17,7 @@
     </button>
     <?php if ($block->hasSplit()): ?>
         <button <?= $block->getToggleAttributesHtml() ?>>
-            <span>Select</span>
+            <span><?= /* @escapeNotVerified */ __('Select'); ?></span>
         </button>
 
         <?php if (!$block->getDisabled()): ?>
@@ -40,12 +40,10 @@
         <?php endif; ?>
     <?php endif; ?>
 </div>
-
-<script>
-    require(['jquery'], function ($) {
-        $('.actions-split')
-            .on('click.splitDefault', '.action-default', function () {
-                $(this).siblings('.dropdown-menu').find('.item-default').trigger('click');
-            });
-    });
-</script>
+<script type="text/x-magento-init">
+    {
+        ".actions-split": {
+            "Magento_Ui/js/grid/controls/button/split": {}
+        }
+    }
+</script>
diff --git a/app/code/Magento/Ui/view/base/web/js/grid/controls/button/split.js b/app/code/Magento/Ui/view/base/web/js/grid/controls/button/split.js
@@ -0,0 +1,17 @@
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+define([
+    'jquery'
+], function ($) {
+    'use strict';
+
+    return function (data, element) {
+
+        $(element).on('click.splitDefault', '.action-default', function () {
+            $(this).siblings('.dropdown-menu').find('.item-default').trigger('click');
+        });
+    };
+});