Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limiter float too generic #15323

Closed
DanielRuf opened this issue May 18, 2018 · 4 comments
Closed

limiter float too generic #15323

DanielRuf opened this issue May 18, 2018 · 4 comments
Assignees
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Release Line: 2.2

Comments

@DanielRuf
Copy link
Contributor

Preconditions

  1. Magento 2.2.4
@media (min-width: 768px), print
.limiter {
    float: right;
}
.products.wrapper ~ .toolbar .pages {
    float: left;
}

Steps to reproduce

  1. inspect toolbar in product list
  2. compare styles of .limiter and .pages

Expected result

  1. .limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts

Actual result

  1. .limiter is too generic and is used as single selector for floating the element
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 18, 2018
@hitesh-wagento
Copy link
Contributor

I working on this

@sidolov
Copy link
Contributor

sidolov commented Jun 13, 2018

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #15880 by @hitesh-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #15879 by @hitesh-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #15878 by @hitesh-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Release Line: 2.2
Projects
None yet
Development

No branches or pull requests

4 participants