Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should redirect to the same page after signup #3367

Closed
SidharthBansal opened this issue Sep 21, 2018 · 77 comments
Closed

Should redirect to the same page after signup #3367

SidharthBansal opened this issue Sep 21, 2018 · 77 comments
Labels
gci-candidate help wanted requires help by anyone willing to contribute
Milestone
Login/SignUp & OAuth

Comments

@SidharthBansal
Copy link
Member

Please describe the problem (or idea)

A person is on the /wiki and then signs up. The person is redirected to the dashboard

What did you expect to see that you didn't?

I should be redirected to the wiki page after log in.

Hint use return_to field
@SidharthBansal SidharthBansal added the help wanted requires help by anyone willing to contribute label Sep 21, 2018
@Rishabh-Kumar-Bothra
Copy link
Contributor

May I take this?

@SidharthBansal
Copy link
Member Author

You are really quick rishabh....
Why not???
Take it...If you need help just ping any of us at pl.
Thanks for contributing here at pl.

@Rishabh-Kumar-Bothra
Copy link
Contributor

OK. Working on it.

@avsingh999
Copy link
Member

It's redirecting after login to same wiki page

@SidharthBansal
Copy link
Member Author

@avsingh999 thanks for your help
I got this error when I was initially at /wiki and then I logged in.
I was redirected to dashboard.

I am not talking of /wiki/_____. That issue was solved by me in month of feb or earlier.

@SidharthBansal
Copy link
Member Author

I checked it. I am facing this error. @geekychaser can you please check whether this is arising at your machine?
Thanks all

@jywarren jywarren mentioned this issue Dec 2, 2019
Closed
@SidharthBansal SidharthBansal added this to the Login/SignUp & OAuth milestone Dec 4, 2019
@SidharthBansal SidharthBansal mentioned this issue Jan 1, 2020
Closed
@SidharthBansal
Copy link
Member Author

@Uzay-G

@SidharthBansal
Copy link
Member Author

Please ensure that this is working after your pr

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 7, 2020 via email

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 7, 2020 via email

@Uzay-G
Copy link
Member

Uzay-G commented Jan 7, 2020

Alright no problem. I will abandon it and then work on some other tasks!
Thanks for your help!

@SidharthBansal
Copy link
Member Author

Sure thanks

@SidharthBansal SidharthBansal changed the title Should redirect to wiki page after signup Should redirect to the same wiki page after signup Jan 7, 2020
@SidharthBansal SidharthBansal changed the title Should redirect to the same wiki page after signup Should redirect to the same page after signup Jan 7, 2020
@publiclab publiclab deleted a comment from Uzay-G Jan 7, 2020
@SidharthBansal
Copy link
Member Author

Hi

@SidharthBansal SidharthBansal reopened this Jan 7, 2020
@SidharthBansal
Copy link
Member Author

Sorry for misunderstanding,
let me clarify you one thing. You need to show DASHBOARD AFTER SIGN UP THROUGH OAUTH
This is the desired functionality.

@SidharthBansal
Copy link
Member Author

Please focus on last comment only.
Do following things in order

  1. Install MK
  2. Install SWB
  3. Get points for both 1 and 2
  4. Set up developer account for Github by link I provided in one of the issues
  5. Try logging in to localhost with Github account.
    Do this much first.

@Uzay-G
Copy link
Member

Uzay-G commented Jan 7, 2020

Ok, sorry for misunderstanding, no need to get mad.
I already did 1-3 and am working on the last 2. I am sorry if I am bothering you with my questions.

@SidharthBansal
Copy link
Member Author

  1. run MK on localhost 3002
  2. run SWB on localhost 3004
  3. run Plots2 on localhost 3000
  4. change https://github.com/publiclab/mapknitter/blob/5f25aa60243918b9d6a8f50a3db862358b25dafa/app/controllers/sessions_controller.rb#L16 to localhost:3000 like thingy. [Important: we don't want step 9 to reflect in any PR]
  5. Try logging in MK through Plots2 form based authentication
  6. Try logging in SWB through Plots2 form based authentication
  7. Try logging in MK through Plots2 GIthub based authentication
  8. Try logging in SWB through Plots2 GIthub based authentication
    do this with and without your changes.

@SidharthBansal
Copy link
Member Author

Even if you are able to set up provider and connect SWB & MK with plots2 you will get 5 points.

@SidharthBansal
Copy link
Member Author

Refer https://github.com/publiclab/plots2/blob/master/doc/LOGIN_SYSTEMS.md for help

@Uzay-G
Copy link
Member

Uzay-G commented Jan 7, 2020

Hey, I managed to get the github app working and can sign up through it with plots2 but I cannot login with Mapknitter. Could you help me?

@SidharthBansal
Copy link
Member Author

Please refer to above steps and tell me where are you having problem?

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 8, 2020 via email

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 8, 2020 via email

@Uzay-G
Copy link
Member

Uzay-G commented Jan 8, 2020 •
edited
Loading

Yeah that's weird.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 8, 2020 via email

@Uzay-G
Copy link
Member

Uzay-G commented Jan 8, 2020 via email

@Uzay-G
Copy link
Member

Uzay-G commented Jan 8, 2020

Are there any issues I need to fix with spectral or MK then?
For plots2,
I already inserted some oauth redirection tests in #7113 and #7072.

Another thing I will fix is that currently, when a user signs up through oauth, they are not redirected to the dashboard. When we merge #7113, I will open a new pull request to fix that.

@Uzay-G Uzay-G mentioned this issue Jan 8, 2020
Merged
@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 8, 2020 via email

@Uzay-G
Copy link
Member

Uzay-G commented Jan 8, 2020

Yeah I already included the tests for plots2 and everything seems fine with MK and SWB. I will work on other tasks in the meantime. Have a nice vacation!

@Uzay-G
Copy link
Member

Uzay-G commented Jan 8, 2020

I will make the other pull requests after so there are no conflicts 👍

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 11, 2020 via email

@Uzay-G
Copy link
Member

Uzay-G commented Jan 11, 2020

Yeah I will make the other pull request but we need to merge these ones first otherwise there will be conflicts between the prs.

@SidharthBansal
Copy link
Member Author

try to add tests in the same pr then

@Uzay-G
Copy link
Member

Uzay-G commented Jan 11, 2020

Well actually my changes are not tests but other fixes, I will include these fixes in the pull requests if you like!

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 11, 2020 via email

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 11, 2020 via email

@Uzay-G
Copy link
Member

Uzay-G commented Jan 11, 2020

I already put the tests in the prs but for example right now on PL, signing up through oauth always redirects to the dashboard.

Since my changes make it return to the previous page instead, I need to make signup through oauth redirect to dashboard instead

@Uzay-G
Copy link
Member

Uzay-G commented Jan 11, 2020

Either open it as a new pr OR as a new single commit in current pr so that
your changes are visible

I will insert the changes in #7113

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Jan 12, 2020 via email

@SidharthBansal
Copy link
Member Author

I will insert the changes in #7113

What have you inserted?

@SidharthBansal SidharthBansal mentioned this issue Jan 12, 2020
Closed
@Uzay-G Uzay-G mentioned this issue Jan 12, 2020
Merged
@SidharthBansal
Copy link
Member Author

task related to this issue is https://codein.withgoogle.com/dashboard/task-instances/5266798652424192/

@SidharthBansal
Copy link
Member Author

@Uzay-G is this issue resolved?

@Uzay-G
Copy link
Member

Uzay-G commented Jan 13, 2020

Currently, the user is redirected to the same page after signpb. But @jywarren and others seemed to say it would be better to redirect to the dashboard when signing up. That's why I opened #7211

@SidharthBansal
Copy link
Member Author

correct. this issue is not needed any more
moved to #7211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gci-candidate help wanted requires help by anyone willing to contribute
Projects
None yet
Milestone
Login/SignUp & OAuth
Development

No branches or pull requests
4 participants
@SidharthBansal @Rishabh-Kumar-Bothra @avsingh999 @Uzay-G