Logging in through MK AND SWB should not redirect to Publiclab #7121

Uzay-G · 2020-01-06T17:53:45Z

The authentication system for Mapknitter, Publiclab and Spectral Workbench are quite intertwined and I noticed that logging it to Mapknitter through oauth (at least Github) redirected to the publiclab dashboard instead of back to Mapknitter. Here's a video with the problem:

Is there a way we could implement a redirect to the website we are currently on instead and do you find this useful? I would love to help! 👍

VladimirMikulic · 2020-01-06T17:56:48Z

I've thought of this issue too. It's annoying when you get redirected every time when you log in via Google/Github...

Uzay-G · 2020-01-06T20:17:27Z

Yeah I totally agree.

jywarren · 2020-01-06T21:21:39Z

Oh huh... let's cc @SidharthBansal because he created this system. I wonder does this happen only for Google/GitHub or for Twitter/FB too?

…

On Mon, Jan 6, 2020 at 3:17 PM Uzay-G ***@***.***> wrote: Yeah I totally agree. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AAAF6J6TGTY5RMCMAHBIO6LQ4OGVRA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIGUZTQ#issuecomment-571296974>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J5HF3W7HE6A4AVT2OTQ4OGVRANCNFSM4KDHU3TA> .

SidharthBansal · 2020-01-07T02:09:13Z

Hi @Uzay-G I was referring to the same thing yesterday in your pr. We need a test to ensure correct behavior for MK and SWB(no redirect back to PL). Can you please add tests demonstrating it also?

SidharthBansal · 2020-01-07T02:10:40Z

@jywarren there were some changes in May-July in plots2 due to which all 4 providers are redirecting back to MK and SWB. We are trying to rectify this on priority. I really appreciate your patience.

SidharthBansal · 2020-01-07T17:29:15Z

@Uzay-G and I am solving it. I hope we will finish this milestone this week. On Tue, Jan 7, 2020 at 2:51 AM Jeffrey Warren <notifications@github.com> wrote:

…

Oh huh... let's cc @SidharthBansal because he created this system. I wonder does this happen only for Google/GitHub or for Twitter/FB too? On Mon, Jan 6, 2020 at 3:17 PM Uzay-G ***@***.***> wrote: > Yeah I totally agree. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > < #7121?email_source=notifications&email_token=AAAF6J6TGTY5RMCMAHBIO6LQ4OGVRA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIGUZTQ#issuecomment-571296974 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAAF6J5HF3W7HE6A4AVT2OTQ4OGVRANCNFSM4KDHU3TA > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AFAAEQ5NPAN2K4EBPZSBQR3Q4OOGJA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIG2M7Q#issuecomment-571319934>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQYIKAQQFRB7WAQXG63Q4OOGJANCNFSM4KDHU3TA> .

jywarren · 2020-01-07T17:31:19Z

Thank you very much!!! On Tue, Jan 7, 2020 at 12:29 PM Sidharth Bansal <notifications@github.com> wrote:

…

@Uzay-G and I am solving it. I hope we will finish this milestone this week. On Tue, Jan 7, 2020 at 2:51 AM Jeffrey Warren ***@***.***> wrote: > Oh huh... let's cc @SidharthBansal because he created this system. I wonder > does this happen only for Google/GitHub or for Twitter/FB too? > > On Mon, Jan 6, 2020 at 3:17 PM Uzay-G ***@***.***> wrote: > > > Yeah I totally agree. > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > < > #7121?email_source=notifications&email_token=AAAF6J6TGTY5RMCMAHBIO6LQ4OGVRA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIGUZTQ#issuecomment-571296974 > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAAF6J5HF3W7HE6A4AVT2OTQ4OGVRANCNFSM4KDHU3TA > > > > . > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #7121?email_source=notifications&email_token=AFAAEQ5NPAN2K4EBPZSBQR3Q4OOGJA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIG2M7Q#issuecomment-571319934 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AFAAEQYIKAQQFRB7WAQXG63Q4OOGJANCNFSM4KDHU3TA > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AAAF6J53XIAZORZMUEPEEUTQ4S3W3A5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJUNFY#issuecomment-571688599>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6JZBAQCPYRB2HW6UFVDQ4S3W3ANCNFSM4KDHU3TA> .

SidharthBansal · 2020-01-12T14:05:14Z

I think this will be solved after #3367

SidharthBansal · 2020-01-13T05:37:14Z

@Uzay-G please provide tests for MK and SWB

SidharthBansal · 2020-01-13T05:37:42Z

If this issue still requires changes then please provide changes too

Uzay-G · 2020-01-13T06:34:45Z

@Uzay-G please provide tests for MK and SWB

@SidharthBansal could you help me with this? I don't think it's possible to test logging in through Publiclab from MK or SWB

SidharthBansal · 2020-01-13T07:14:26Z

This will help you

https://github.com/publiclab/plots2/blob/d06f59460edf0424a6edbfc4000ac8444145fc5d/test/integration/openid_test.rb

SidharthBansal · 2020-01-13T07:15:21Z

Let's focus on completing login milestone asap. So, that we can start working on other projects like comments, stats too together

SidharthBansal · 2020-01-13T07:15:45Z

You can take as much time as you want. Don't need to take tension.

Uzay-G · 2020-01-13T18:03:24Z

Hey! I checked out the file and I was wondering what type of tests you wanted me to add. Do you want me to add tests for trying to log in with banned users and things like that?

SidharthBansal · 2020-01-13T18:22:07Z

User at Mk in not logged in state. User clicks Github Provider. Github is logged in Pl is logged in MK is logged in User is logged into MK User is on mk.org Similarly for all provider, similarly for both signup and login and for both swb and mk. Does this make sense?

…

On Mon, Jan 13, 2020 at 11:33 PM Uzay-G ***@***.***> wrote: Hey! I checked out the file and I was wondering what type of tests you wanted me to add. Do you want me to add tests for trying to log in with banned users and things like that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AFAAEQ5H7ZDAEQHKHB3VPT3Q5SUGZA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZV7GA#issuecomment-573792152>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ5W2SGJPHF32HNX5SDQ5SUGZANCNFSM4KDHU3TA> .

Uzay-G · 2020-01-13T18:23:52Z

Yeah it does. I am looking at the example you sent and will try and code some tests 👍

SidharthBansal · 2020-01-13T18:26:58Z

There will be many tests. Please ensure no duplicate tests

…

On Mon, Jan 13, 2020 at 11:53 PM Uzay-G ***@***.***> wrote: Yeah it does. I am looking at the example you sent and will try and code some tests 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AFAAEQ3PVUPYP7RZCPEFR5TQ5SWTRA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZYHQY#issuecomment-573801411>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQYTLU7ELQ6JUL3ZWOLQ5SWTRANCNFSM4KDHU3TA> .

Uzay-G · 2020-01-13T22:08:45Z

Hey! Don't some of these tests: https://github.com/publiclab/plots2/blob/d06f59460edf0424a6edbfc4000ac8444145fc5d/test/integration/openid_test.rb already do authentication requests from MK or SWB?

SidharthBansal · 2020-01-14T05:12:35Z

yes we already have some tests. we need to write remaining tests if any

…

On Tue, Jan 14, 2020 at 3:38 AM Uzay-G ***@***.***> wrote: Hey! Don't some of these tests: https://github.com/publiclab/plots2/blob/d06f59460edf0424a6edbfc4000ac8444145fc5d/test/integration/openid_test.rb already do authentication requests from MK or SWB? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AFAAEQZI7TY4YZKGNJKQO4DQ5TQ65A5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI2PIYY#issuecomment-573895779>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ442KCMFJIDVJHWN23Q5TQ65ANCNFSM4KDHU3TA> .

Uzay-G · 2020-01-15T09:29:19Z

All of the tests in the file are only for SWB, should I replicate them for MK?

SidharthBansal · 2020-01-15T11:43:46Z

There should be tests for mk too

…

On Wed, 15 Jan 2020, 2:59 pm Uzay-G, ***@***.***> wrote: All of the tests in the file are only for SWB, should I replicate them for MK? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AFAAEQ6X5X5I42WNF5J46ATQ53JPBA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI7USFQ#issuecomment-574572822>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ2GYS5KFNVCOH6XAM3Q53JPBANCNFSM4KDHU3TA> .

Uzay-G · 2020-01-15T12:45:32Z

The tests are quite confusing... I have done the missing tests for MK based on what already existed for SWB but I am not sure what I can add and how I can test through the open_id. What other tests should I add to the files?

SidharthBansal · 2020-01-15T13:57:38Z

Let's first merge a pr so that equal number of tests are present for mk and swb. Then we can think forward.

…

On Wed, 15 Jan 2020, 6:15 pm Uzay-G, ***@***.***> wrote: The tests are quite confusing... I have done the missing tests for MK based on what already existed for SWB but I am not sure what I can add and how I can test through the open_id. What other tests should I add to the files? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AFAAEQ2IC3KFBMK7XHFWU2TQ54AO3A5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJAF6WA#issuecomment-574644056>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ54VTSPENZMQGQWBMDQ54AO3ANCNFSM4KDHU3TA> .

Uzay-G · 2020-01-15T13:59:13Z

Alright I will open the pull request 👍

SidharthBansal · 2020-01-15T16:25:02Z

Now we can continue with other tests

Uzay-G · 2020-01-15T17:19:01Z

What type of tests would you like me to add?

SidharthBansal · 2020-01-15T17:52:44Z

Login to mk by logging into GitHub at public lab. Redirected back to mk.

…

On Wed, 15 Jan 2020, 10:49 pm Uzay-G, ***@***.***> wrote: What type of tests would you like me to add? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7121?email_source=notifications&email_token=AFAAEQ3DSJB6RXPOU5DJBG3Q55AQNA5CNFSM4KDHU3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBC7RI#issuecomment-574762949>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ5GOTKQJGKRMTSBCGTQ55AQNANCNFSM4KDHU3TA> .

Uzay-G · 2020-01-15T18:15:39Z

Doesn't this one solve that:

plots2/test/integration/openid_test.rb

Lines 338 to 391 in 299a6f4

    
           test 'Mapknitter openid authentication request for Github Provider' do 
        
             # test using Github Provider button on MK or SWB 
        
             # log in 
        
             post '/user_sessions', params: { user_session: { username: users(:jeff).username, password: 'secretive' } } 
        
             follow_redirect! 
        
             get '/openid', params: { 
        
               'openid.claimed_id': "https://mapknitter.org/openid/#{users(:jeff).username}/github", 
        
               'openid.identity': "https://mapknitter.org/openid/#{users(:jeff).username}/github", 
        
               'openid.mode': 'checkid_setup', 
        
               'openid.ns': 'http://specs.openid.net/auth/2.0', 
        
               'openid.ns.sreg': 'http://openid.net/extensions/sreg/1.1', 
        
               'openid.realm': 'https://mapknitter.org/', 
        
               'openid.return_to': "https://mapknitter.org/session/new?authenticity_token=RcLcGH3lzSTCC24UpPnNm56sllNaMrHg5%2FSrQzNxB%2B4%3D&back_to=&open_id=#{users(:jeff).username}/github&return_to=", 
        
               'openid.sreg.required': 'nickname,email,fullname' 
        
             } 
        
             assert_nil flash[:error] 
        
             assert_response :found 
        
             assert_routing({ path: path, method: :get }, { controller: 'openid', action: 'index' }) 
        
             ## now same with POST 
        
             # More complete parameters: 
        
             # {"authenticity_token"=>"RcLcGH3lzSTCC24UpPnNm56sllNaMrHg5/SrQzNxB+4=", "back_to"=>"/", "open_id"=>"warren", "openid.assoc_handle"=>"{HMAC-SHA1}{5b1d5a10}{bGMKfQ==}", "openid.claimed_id"=>"http://localhost:3000/openid/warren", "openid.identity"=>"http://localhost:3000/openid/warren", "openid.mode"=>"check_authentication", "openid.ns"=>"http://specs.openid.net/auth/2.0", "openid.ns.sreg"=>"http://openid.net/extensions/sreg/1.1", "openid.op_endpoint"=>"http://localhost:3000/openid", "openid.response_nonce"=>"2018-06-10T17:04:16ZSTb7YI", "openid.return_to"=>"http://localhost:3001/session/new?authenticity_token=RcLcGH3lzSTCC24UpPnNm56sllNaMrHg5%2FSrQzNxB%2B4%3D&back_to=%2F&open_id=warren&return_to=%2F", "openid.sig"=>"cElPJYRTb7IDCsZe3eLx639cchg=", "openid.signed"=>"assoc_handle,claimed_id,identity,mode,ns,ns.sreg,op_endpoint,response_nonce,return_to,signed,sreg.email,sreg.nickname", "openid.sreg.email"=>"jeff@unterbahn.com", "openid.sreg.nickname"=>"warren", "return_to"=>"/"} 
        
             post '/openid?openid.claimed_id=' + users(:jeff).username, params: { 
        
               'openid.claimed_id': "https://mapknitter.org/openid/#{users(:jeff).username}/github", 
        
               'openid.identity': "https://mapknitter.org/openid/#{users(:jeff).username}/github", 
        
               'openid.mode': 'checkid_setup', 
        
               'openid.ns': 'http://specs.openid.net/auth/2.0', 
        
               'openid.ns.sreg': 'http://openid.net/extensions/sreg/1.1', 
        
               'openid.realm': 'https://mapknitter.org/', 
        
               'openid.return_to': "https://mapknitter.org/session/new?authenticity_token=RcLcGH3lzSTCC24UpPnNm56sllNaMrHg5%2FSrQzNxB%2B4%3D&back_to=&open_id=#{users(:jeff).username}/github&return_to=", 
        
               'openid.sreg.required': 'nickname,email,fullname' 
        
             } 
        
             assert_nil flash[:error] 
        
             assert_response :found 
        
             assert_routing({ path: path, method: :post }, { controller: 'openid', action: 'index' }) 
        
             # Then, 'openid authentication approval goes to decision page'  -- based on same session 
        
             # log in 
        
             post '/user_sessions', params: { user_session: { username: users(:jeff).username, password: 'secretive' } } 
        
             follow_redirect! 
        
             post '/openid/decision', params: { 
        
               "authenticity_token": "RcLcGH3lzSTCC24UpPnNm56sllNaMrHg5%2FSrQzNxB%2B4%3D", 
        
               "yes": "Yes" 
        
             } 
        
             # redirects back to originating site 
        
             assert_match /https:\/\/mapknitter.org\/session\/new/, @response.redirect_url 
        
           end

Maybe I am wrong. What do you think?

SidharthBansal · 2020-01-15T18:25:55Z

Please abandon the current task. I think we can go to the system tests now

SidharthBansal · 2020-01-15T18:26:22Z

Sorry I can't give points for this as it was already solved

Uzay-G · 2020-01-15T18:28:18Z

Yeah no problem 👍

Uzay-G added the feature explains that the issue is to add a new feature label Jan 6, 2020

SidharthBansal added this to the Login/SignUp & OAuth milestone Jan 7, 2020

SidharthBansal changed the title ~~Logging in through Mapknitter should not redirect to Publiclab~~ Logging in through MK AND SWB should not redirect to Publiclab Jan 13, 2020

SidharthBansal closed this as completed Jan 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logging in through MK AND SWB should not redirect to Publiclab #7121

Logging in through MK AND SWB should not redirect to Publiclab #7121

Uzay-G commented Jan 6, 2020

VladimirMikulic commented Jan 6, 2020

Uzay-G commented Jan 6, 2020

jywarren commented Jan 6, 2020 via email

SidharthBansal commented Jan 7, 2020

SidharthBansal commented Jan 7, 2020

SidharthBansal commented Jan 7, 2020 via email

jywarren commented Jan 7, 2020 via email

SidharthBansal commented Jan 12, 2020

SidharthBansal commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020

Uzay-G commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020

Uzay-G commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020 via email

Uzay-G commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020 via email

Uzay-G commented Jan 13, 2020

SidharthBansal commented Jan 14, 2020 via email

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020 via email

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020 via email

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020 via email

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020

Uzay-G commented Jan 15, 2020

Logging in through MK AND SWB should not redirect to Publiclab #7121

Logging in through MK AND SWB should not redirect to Publiclab #7121

Comments

Uzay-G commented Jan 6, 2020

VladimirMikulic commented Jan 6, 2020

Uzay-G commented Jan 6, 2020

jywarren commented Jan 6, 2020 via email

SidharthBansal commented Jan 7, 2020

SidharthBansal commented Jan 7, 2020

SidharthBansal commented Jan 7, 2020 via email

jywarren commented Jan 7, 2020 via email

SidharthBansal commented Jan 12, 2020

SidharthBansal commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020

Uzay-G commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020

Uzay-G commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020 via email

Uzay-G commented Jan 13, 2020

SidharthBansal commented Jan 13, 2020 via email

Uzay-G commented Jan 13, 2020

SidharthBansal commented Jan 14, 2020 via email

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020 via email

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020 via email

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020 via email

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020

SidharthBansal commented Jan 15, 2020

Uzay-G commented Jan 15, 2020