Redirection after oauth SIGNUP

[Uzay-G]

After #7113, oauth should be correctly redirecting to the previous page the user was on before he logged in/signed up.

Now there has been lots of discussion around where users should be redirected after signing up. This was summed up by @jywarren in #6233:

I'm thinking about the discussion of whether on SIGNUP we want to leave people on the dashboard or on the page they came from, so that's unrelated to this issue on LOGIN.

Signup-related issues have sometimes been opened to suggest that people end up back where they came from but my understanding is that they need to arrive on the dashboard to see the "welcome message". Related issues:

#3367
#5600 (not sure if this is signup or login)

But, possibly related to this issue: #3246

Thanks!

For now, signing up through oauth will redirect to the previous page the user was on. But I think we should discuss this issue of redirection for signing up.

I would be happy to change the code to redirect the user to the dashboard after signing up through oauth.

What do you think @jywarren and @SidharthBansal?

[Uzay-G]

@SidharthBansal can you add this to the login/signup milestones? Thanks 👍

[SidharthBansal]

do we need to solve this before merging other prs?
Or can we do this later?
Any idea?

[Uzay-G]

We can solve this after #7113. We need to discuss how we want this redirection to work and then implement the changes.

[SidharthBansal]

@Uzay-G can we proceed with this now?
Which tests were you going to add?
Please open a new issue so that we can discuss them there.

[Uzay-G]

Yes, if we want to redirect to the dashboard after oauth signup we should work on this. Otherwise we can leave it as is and the user will be redirected to the previous page when signing up. I will open a new issue for the tests.

[SidharthBansal]

Can you please close this issue and open up a new issue after refactoring #7211?

[SidharthBansal]

We just need to migrate as it is difficult to understand things here

[Uzay-G]

You want me to close this one and open a new one after refactoring which pr/issue?

[SidharthBansal]

7211

…

On Tue, 14 Jan 2020, 12:28 am Uzay-G, ***@***.***> wrote: You want me to close this one and open a new one after refactoring which pr/issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7211?email_source=notifications&email_token=AFAAEQ4OQUPFAXREYWL4W6LQ5S2XHA5CNFSM4KFYHWF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZ4B7A#issuecomment-573817084>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ5G5OHXMPRSAWCHZDDQ5S2XHANCNFSM4KFYHWFQ> .

[Uzay-G]

Sorry I don't understand this issue is 7211

[SidharthBansal]

Just I need you to reformat the current issue for view from Jefd

…

On Tue, 14 Jan 2020, 12:31 am Uzay-G, ***@***.***> wrote: Sorry I don't understand this issue is 7211 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7211?email_source=notifications&email_token=AFAAEQ7MZ4U2AKALKRWECZTQ5S3ADA5CNFSM4KFYHWF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZ4KHQ#issuecomment-573818142>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ4PJWDNL7SLDAEF3RDQ5S3ADANCNFSM4KFYHWFQ> .

[SidharthBansal]

Moved to #7240

[Uzay-G]

Sorry I was going to work on this but didn't have any time today. Thank you so much for opening the issue!