Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

102 select all #225

Merged
merged 1 commit into from
Aug 5, 2020
Merged

102 select all #225

merged 1 commit into from
Aug 5, 2020

Conversation

cdmo
Copy link
Contributor

@cdmo cdmo commented Jul 30, 2020 •
edited
Loading

#102

after: #219

Removes visible label from "Select all" option. Also:

  • "De-flattens" the buttons
  • Change queue position column to be a simple ordinal value.
  • Updates Sidekiq gem to the latest

@cdmo cdmo added this to the 0.3.x Theming and Final Prep milestone Jul 30, 2020
@cdmo cdmo requested a review from banukutlu July 30, 2020 18:25
@cdmo cdmo self-assigned this Jul 30, 2020
@cdmo cdmo force-pushed the 102-select-all branch from 071ad86 to 6d6d988 Compare July 30, 2020 18:35
@cdmo cdmo mentioned this pull request Jul 30, 2020
Merged
@banukutlu
Copy link
Contributor

banukutlu commented Aug 5, 2020 •
edited
Loading

@cdmo I'm ready to review this PR, rebase pls when you can :)

Removes visible label from "Select all" option. Also:
a320f8c 
* "De-flattens" the buttons
* Change queue position column to be a simple ordinal value.
* Updates Sidekiq gem to the latest
* Removes top Renew button
banukutlu
banukutlu approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@banukutlu banukutlu merged commit 4385dc0 into master Aug 5, 2020
@banukutlu banukutlu deleted the 102-select-all branch August 5, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banukutlu banukutlu banukutlu approved these changes

Assignees

@cdmo cdmo

Labels
None yet
Projects
None yet
Milestone
0.3.x Theming and Final Prep
Development

Successfully merging this pull request may close these issues.
2 participants
@cdmo @banukutlu