Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

215 actionview deprecation and upgrade #219

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

cdmo
Copy link
Contributor

@cdmo cdmo commented Jul 28, 2020

#215

After #218

Also updated the README to remove dev caching instruction which is not needed anymore

@cdmo cdmo added this to the 0.3.x Theming and Final Prep milestone Jul 28, 2020
@cdmo cdmo requested a review from banukutlu July 28, 2020 18:45
@cdmo cdmo self-assigned this Jul 28, 2020
@cdmo cdmo temporarily deployed to myaccount-qa July 28, 2020 18:47 Inactive
@cdmo cdmo mentioned this pull request Jul 30, 2020
@banukutlu
Copy link
Contributor

@cdmo I am ready to review this now, sorry need another rebase :)

@cdmo
Copy link
Contributor Author

cdmo commented Aug 5, 2020

no worries, I expected all the rebases and they're easy peasy.

… README to denote no need for dev caching flag.
@cdmo cdmo force-pushed the 215-actionview-deprecation-and-upgrade branch from 1ceebda to b83a0cb Compare August 5, 2020 15:28
@cdmo cdmo temporarily deployed to myaccount-qa August 5, 2020 15:44 Inactive
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@banukutlu banukutlu merged commit 59e66ba into master Aug 5, 2020
@banukutlu banukutlu deleted the 215-actionview-deprecation-and-upgrade branch August 5, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants