Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish select all component #102

Closed
cdmo opened this issue Jan 31, 2020 · 3 comments
Closed

Polish select all component #102

cdmo opened this issue Jan 31, 2020 · 3 comments
Assignees

Comments

@cdmo
Copy link
Contributor

cdmo commented Jan 31, 2020

Like make the label text and placing consistent in holds and checkouts and make it... good.

See #83 (comment)

@cdmo cdmo added this to the 0.2.x Theming and Final Prep milestone Jan 31, 2020
@cdmo cdmo self-assigned this Jul 29, 2020
@cdmo
Copy link
Contributor Author

cdmo commented Jul 29, 2020

Hi @ruthtillman would you mind letting me know your thoughts on options for refactoring the display/behavior of select all:

option 1

One option is to remove the first column called "Select" and merge it with "Item" and then have a checkbox next to Item in the table header that can select all items. This would require an aria-label to ensure that it would make sense to unsighted users.

See https://material-ui.com/components/tables/#sorting-amp-selecting

option 2

Another option is to do what is done in elibrary, essentially an empty row that is just for the "All" checkbox.

Screen Shot 2020-07-29 at 1 12 32 PM

option 3

Another option might be to make companion "all" buttons. Sort of like below, but for every hold and renew button.

Screen Shot 2020-07-29 at 1 16 17 PM

I'm not sure which I like best to tell the truth. But I think it's the companion "all" buttons OR the merging of select and item columns.

option 4: leave it as is

Maybe a final option is to leave the select alls looking like they do now and say it's good enough.

@cdmo cdmo added the question Further information is requested label Jul 29, 2020
@ruthtillman
Copy link
Collaborator

I also like Options 1 and 3. I think that users probably do expect a "select all" option, so perhaps Option 1? Would the checkbox clearly be for all items for sighted users as well? I'm thinking that sometimes without appropriate textual labeling such boxes aren't entirely clear.

@cdmo
Copy link
Contributor Author

cdmo commented Jul 29, 2020

It is always tricky to walk the line between "simplifying the interface" and "providing enough context" for best usability IMO. I'll go with option 1 and try to get some options for how that will look. Thanks

@cdmo cdmo removed the question Further information is requested label Jul 29, 2020
@cdmo cdmo mentioned this issue Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants