Skip to content

Commit a67ed4f

Browse files
authored
Merge pull request #91 from joshmoore/cleanup-builds
Cleanup builds
2 parents 53424e6 + d79c393 commit a67ed4f

File tree

9 files changed

+20
-42
lines changed

9 files changed

+20
-42
lines changed

.github/workflows/build.yml

+11-27
Original file line numberDiff line numberDiff line change
@@ -10,33 +10,17 @@ jobs:
1010
fail-fast: false
1111
matrix:
1212
include:
13-
14-
- {os: windows-latest, python_Version: '3.6', toxenv: 'py36-PyQt5'}
15-
- {os: windows-latest, python_Version: '3.6', toxenv: 'py36-PySide2'}
16-
- {os: windows-latest, python_Version: '3.7', toxenv: 'py37-PyQt5'}
17-
- {os: windows-latest, python_Version: '3.7', toxenv: 'py37-PySide2'}
18-
- {os: windows-latest, python_Version: '3.8', toxenv: 'py38-PyQt5'}
19-
- {os: windows-latest, python_Version: '3.8', toxenv: 'py38-PySide2'}
20-
- {os: windows-latest, python_Version: '3.9', toxenv: 'py39-PyQt5'}
21-
- {os: windows-latest, python_Version: '3.9', toxenv: 'py39-PySide2'}
22-
23-
# No Python 3.6
24-
# Linux all failing on GHA
25-
# {os: linux-latest, python_Version: '3.7', toxenv: 'py37-PyQt5'}
26-
# {os: linux-latest, python_Version: '3.7', toxenv: 'py37-PySide2'}
27-
# {os: linux-latest, python_Version: '3.8', toxenv: 'py38-PyQt5'}
28-
# {os: linux-latest, python_Version: '3.8', toxenv: 'py38-PySide2'}
29-
# {os: linux-latest, python_Version: '3.9', toxenv: 'py39-PyQt5'}
30-
# {os: linux-latest, python_Version: '3.9', toxenv: 'py39-PySide2'}
31-
32-
# No Python 3.6
33-
- {os: macos-latest, python_Version: '3.7', toxenv: 'py37-PyQt5'}
34-
- {os: macos-latest, python_Version: '3.7', toxenv: 'py37-PySide2'}
35-
- {os: macos-latest, python_Version: '3.8', toxenv: 'py38-PyQt5'}
36-
- {os: macos-latest, python_Version: '3.8', toxenv: 'py38-PySide2'}
13+
- {os: windows-latest, python_Version: '3.7', toxenv: 'py37'}
14+
- {os: windows-latest, python_Version: '3.8', toxenv: 'py38'}
15+
- {os: windows-latest, python_Version: '3.9', toxenv: 'py39'}
16+
# Linux still not working
17+
# {os: linux-latest, python_Version: '3.7', toxenv: 'py37'}
18+
# {os: linux-latest, python_Version: '3.8', toxenv: 'py38'}
19+
# {os: linux-latest, python_Version: '3.9', toxenv: 'py39'}
20+
- {os: macos-latest, python_Version: '3.7', toxenv: 'py37'}
21+
- {os: macos-latest, python_Version: '3.8', toxenv: 'py38'}
3722
# missing numcodecs wheels on 3.9. conda not yet an option. see gh-51
38-
# {os: macos-latest, python_Version: '3.9', toxenv: 'py39-PyQt5'}
39-
# {os: macos-latest, python_Version: '3.9', toxenv: 'py39-PySide2'}
23+
# {os: macos-latest, python_Version: '3.9', toxenv: 'py39'}
4024

4125
steps:
4226
- uses: actions/checkout@v1
@@ -77,7 +61,7 @@ jobs:
7761
python -m pip install -r requirements/requirements-dev.txt
7862
7963
- name: Test
80-
run: tox -e 'py37-PyQt5-coverage'
64+
run: tox -e 'py37-coverage'
8165

8266
- uses: codecov/codecov-action@v1
8367
with:

.github/workflows/pre.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ jobs:
1717
fail-fast: false
1818
matrix:
1919
include:
20-
- {os: windows-latest, python_Version: '3.9', toxenv: 'py39-PySide2'}
21-
- {os: macos-latest, python_Version: '3.8', toxenv: 'py38-PyQt5'}
20+
- {os: windows-latest, python_Version: '3.9', toxenv: 'py39'}
21+
- {os: macos-latest, python_Version: '3.8', toxenv: 'py38'}
2222

2323
steps:
2424
- uses: actions/checkout@v1

.github/workflows/zarr-dev.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ jobs:
3838
- name: Install dependencies
3939
shell: bash -l {0}
4040
run: |
41-
python -m pip install --upgrade pip wheel pytest tox .[napari]
41+
python -m pip install --upgrade pip wheel pytest tox
4242
python -m pip install \
4343
git+https://github.com/zarr-developers/zarr-python.git@master
4444
4545
- name: Run pytest
4646
shell: bash -l {0}
47-
run: pytest --ignore=tests/test_napari.py # segfaults
47+
run: pytest

.isort.cfg

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[settings]
2-
known_third_party = cv2,dask,numpy,pytest,scipy,setuptools,skimage,vispy,zarr
2+
known_third_party = cv2,dask,numpy,pytest,scipy,setuptools,skimage,zarr
33
multi_line_output=6
44
include_trailing_comma=False
55
force_grid_wrap=0

ome_zarr/reader.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import dask.array as da
99
import numpy as np
1010
from dask import delayed
11-
from vispy.color import Colormap
1211

1312
from .io import ZarrLocation
1413
from .types import JSONDict
@@ -336,7 +335,7 @@ def __init__(self, node: Node) -> None:
336335
# TODO: make this value an enumeration
337336
if model == "greyscale":
338337
rgb = [1, 1, 1]
339-
colormaps.append(Colormap([[0, 0, 0], rgb]))
338+
colormaps.append([[0, 0, 0], rgb])
340339

341340
label = ch.get("label", None)
342341
if label is not None:

requirements/requirements-dev.txt

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
black
2-
napari
32
cython >= 0.29.16
43
numpy >= 1.16.0
54
pre-commit

requirements/requirements-test.txt

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
pytest
22
pytest-cov
3-
pytest-qt
43
codecov

setup.py

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ def read(fname):
2424
install_requires += (["requests"],)
2525
install_requires += (["scikit-image"],)
2626
install_requires += (["toolz"],)
27-
install_requires += (["vispy"],)
2827
install_requires += (["opencv-contrib-python-headless"],)
2928

3029

tox.ini

+3-5
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,20 @@
44
# and then run "tox" from this directory.
55

66
[tox]
7-
envlist = py36-{PyQt5, PySide2}, py37-{PyQt5, PySide2}, py38-{PyQt5, PySide2}, py39-{PyQt5, PySide2}
7+
envlist = py37, py38, py39
88

99
[testenv]
1010
# passenv = DISPLAY XAUTHORITY
1111
passenv = GITHUB_ACTIONS
1212
deps =
1313
-rrequirements/requirements-dev.txt
1414
pytest-xvfb ; sys_platform == 'linux'
15-
PyQt5: PyQt5!=5.15.0
16-
PySide2: PySide2!=5.15.0
1715

1816
commands =
1917
pytest {posargs:tests -s}
2018

21-
[testenv:py37-PyQt5-coverage]
19+
[testenv:py37-coverage]
2220
usedevelop = true
2321
commands =
24-
pytest --cov-report=xml --cov=./ome_zarr --cov-append -k "not qt" {posargs:-v}
22+
pytest --cov-report=xml --cov=./ome_zarr --cov-append {posargs:-v}
2523
codecov -f codecov.xml

0 commit comments

Comments
 (0)