fix(frontend)!: Restrict capturing mutable variable in lambdas

[vezenovm]

Description

Problem*

Resolves #4795

Summary*

We now restrict capturing mutable variables that are not mutable references in lambdas.
This is now banned:

fn main() {
    let mut x = 3;

    let f = || {
        x += 2;
    };

    f();
    assert(x == 5);
}

A mutable reference must be used for x instead.

We can still capture a mutable variable if it is only ever used immutably.
e.g. this code is still allowed:

fn main() {
        let mut x = 3;
        let f = || x;
        let _x2 = f();
        assert(x == 3);
   }

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[vezenovm]

Looks like the dispatch aztec-nr macro is going to need updating.

Fix here: AztecProtocol/aztec-packages#12311

[asterite]

I think this doesn't completely solve the issue, though it solves one case of it.

For example I think this code should also be banned:

fn main() {
    let mut x = 3;

    let f = || mutate(&mut x);

    f();
    assert(x == 3);
}

fn mutate(x: &mut Field) {
    *x = 5;
}

And this one:

struct Foo {
    value: Field,
}

impl Foo {
    fn mutate(&mut self) {
        self.value = 2;
    }
}

fn main() {
    let mut foo = Foo { value: 1 };

    let f = || foo.mutate();

    f();

    println(foo);
}

(no need to fix those in this PR, though!)

[vezenovm]

(no need to fix those in this PR, though!)

With the PR updates I just pushed, these are also banned now. I have added tests for these cases as well as nested lambdas.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 10e4639	Previous: c2022f4	Ratio
noir-lang_noir_bigcurve_	243 s	199 s	1.22

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[jfecher]

LGTM. Thank you!