New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm unused methods #12544

Open

nventuro wants to merge 2 commits into master from nv/rm-add-nullif-note

+6 −35

Contributor

nventuro commented Mar 6, 2025

We got rid of addNullifiedNote in #11822, I imagine it accidentally came back in the recent refactors.

I also got rid of addNote since we always use addNotes anyway.


          rm unused methods

303d130

nventuro requested a review from Thunkar

March 6, 2025 19:35


          Fix broken test

d996224

nventuro enabled auto-merge (squash)

March 6, 2025 21:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet