chore(ssa): Turn the Brillig constraints check back on by default

[rkarabut]

Description

As the reasons of the major compile time performance hit on certain large unrolled functions (e.g. rollup-block-root) have been figured out and eliminated in #7190 after temporarily switching the Brillig constraints check off by default in #7211, turn the check back on.

Problem

Summary

Reverts #7211

Additional Context

Documentation

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[rkarabut]

@aakoshh, also changed tracking to employ a HashSet<(FunctionId, InstructionId)> instead of the count, as that one did in fact lead to some strange miscounts on tests with the check back on, and moved the tracking logic entirely out of TaintedIds to clean it up. Seems to be fine performance wise.

[github-actions]

Compilation Time

Benchmark suite	Current: 7e82c04	Previous: b55dbb9	Ratio
sha256_regression	1.1 s	0.984 s	1.12
regression_4709	0.73 s	0.684 s	1.07
ram_blowup_regression	21.5 s	21 s	1.02
global_var_regression_entry_points	0.532 s	0.512 s	1.04
private-kernel-inner	2.334 s	2.104 s	1.11
private-kernel-reset	7.022 s	6.44 s	1.09
private-kernel-tail	1.01 s	0.981 s	1.03
rollup-base-private	18.38 s	14.3 s	1.29
rollup-base-public	11.38 s	10.64 s	1.07
rollup-block-root-empty	0.945 s	0.944 s	1.00
rollup-block-root-single-tx	104 s	99.3 s	1.05
rollup-block-root	145 s	101 s	1.44
rollup-merge	0.959 s	0.923 s	1.04
rollup-root	1.592 s	1.482 s	1.07

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Execution Time

Benchmark suite	Current: 7e82c04	Previous: b55dbb9	Ratio
private-kernel-inner	0.069 s	0.07 s	0.99
private-kernel-reset	0.287 s	0.283 s	1.01
private-kernel-tail	0.016 s	0.016 s	1
rollup-base-private	0.891 s	0.847 s	1.05
rollup-base-public	0.595 s	0.6 s	0.99
rollup-block-root	16.3 s	16.1 s	1.01
rollup-merge	0.006 s	0.006 s	1
rollup-root	0.026 s	0.024 s	1.08

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Test Suite Duration

Benchmark suite	Current: 7e82c04	Previous: b55dbb9	Ratio
AztecProtocol_aztec-packages_noir-projects_aztec-nr	46 s	42 s	1.10
AztecProtocol_aztec-packages_noir-projects_noir-contracts	76 s	76 s	1
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob	44 s	47 s	0.94
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib	164 s	170 s	0.96
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib	10 s	10 s	1
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib	164 s	153 s	1.07
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types	55 s	54 s	1.02
noir-lang_noir-bignum_	75 s	73 s	1.03
noir-lang_noir_bigcurve_	223 s	225 s	0.99
noir-lang_noir_json_parser_	8 s	9 s	0.89

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Execution Memory

Benchmark suite	Current: 7e82c04	Previous: b55dbb9	Ratio
private-kernel-inner	244.72 MB	244.72 MB	1
private-kernel-reset	278.97 MB	278.97 MB	1
private-kernel-tail	214.34 MB	214.34 MB	1
rollup-base-private	579.32 MB	579.32 MB	1
rollup-base-public	487.98 MB	487.98 MB	1
rollup-block-root	1420 MB	1420 MB	1
rollup-merge	348.85 MB	348.85 MB	1
rollup-root	355.85 MB	355.84 MB	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Compilation Memory

Benchmark suite	Current: 7e82c04	Previous: b55dbb9	Ratio
private-kernel-inner	304.82 MB	304.82 MB	1
private-kernel-reset	614.66 MB	614.66 MB	1
private-kernel-tail	228.47 MB	228.48 MB	1.00
rollup-base-private	1390 MB	1390 MB	1
rollup-base-public	1140 MB	1140 MB	1
rollup-block-root-empty	365.86 MB	365.87 MB	1.00
rollup-block-root-single-tx	7870 MB	7870 MB	1
rollup-block-root	7870 MB	7870 MB	1
rollup-merge	364.29 MB	364.28 MB	1.00
rollup-root	411.83 MB	411.83 MB	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 494e750	Previous: 31cc6a1	Ratio
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob	64 s	51 s	1.25

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[aakoshh]

👍

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 7e82c04	Previous: b55dbb9	Ratio
rollup-base-private	18.38 s	14.3 s	1.29
rollup-block-root	145 s	101 s	1.44

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

🚀 Deployed on https://67c5baa8fcfb6a14b443c85e--noir-docs.netlify.app

[rkarabut]

@TomAFrench is this okay to merge?

[TomAFrench]

Sure, I'm fine with this

[github-actions]

FYI @noir-lang/developerrelations on Noir doc changes.