Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with original ISO Rice document and optional cover page styles #35

Closed
ronaldtse opened this issue Dec 3, 2019 · 13 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Dec 3, 2019

@Intelligent2013 this issue is to visually align 100% (if possible) with the original ISO Rice document:

https://github.com/metanorma/mn-samples-iso/blob/master/reference-docs/iso-rice-sample.pdf

Notice that the cover page is different. This is the cover page for "Published" documents. The Word DOC version cover page is for "Unpublished" documents. We will need to allow generating both types of cover pages.

Originally posted by @ronaldtse in #34 (comment)

@ronaldtse ronaldtse changed the title Align fully with original ISO Rice document Align with original ISO Rice document and optional cover page styles Dec 3, 2019
@ronaldtse ronaldtse added the enhancement New feature or request label Dec 3, 2019
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Dec 5, 2019

@ronaldtse Unfortunately, I can't open PDF locally:
image

Looks like file is corrupted. PDF file size is 1 459 350 bytes, have correct header %PDF-1.5.
Could you attach it here, please?

@ronaldtse
Copy link
Contributor Author

I edited the file using Preview, maybe that's the problem.

The original file is this: https://github.com/metanorma/mn-samples-iso/blob/master/reference-docs/model_document-rice_model.pdf

The file I uploaded was edited from the original by removing the commenting pages. Can you do that and upload the new "un-corrupt" file? Thanks.

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Dec 5, 2019

Thank you. I've tried update, but haven't access for mn-samples-iso repository.

@ronaldtse
Copy link
Contributor Author

@Intelligent2013 you now have access!

@Intelligent2013
Copy link
Contributor

@ronaldtse Something wrong...
remote: Permission to metanorma/mn-samples-iso.git denied to Intelligent2013. fatal: unable to access 'https://github.com/metanorma/mn-samples-iso/': The requested URL returned error: 403

@ronaldtse
Copy link
Contributor Author

Sorry maybe a mistake, can you try again?

@Intelligent2013
Copy link
Contributor

PDF updated successfully. Thanks.

@Intelligent2013
Copy link
Contributor

Notice that the cover page is different. This is the cover page for "Published" documents. The Word DOC version cover page is for "Unpublished" documents. We will need to allow generating both types of cover pages.

Is there some tag in xml to determine 'Published' or 'Unpublished' document?

@ronaldtse
Copy link
Contributor Author

@Intelligent2013 yes, in ISO documents, it has //bibdata/status/:

  <status>
    <stage>30</stage>
    <substage>92</substage>
  </status>

The <stage> and <substage> values are well defined, as the International Harmonized Stage Codes (https://www.iso.org/stage-codes.html):

  • stage 60 means published, everything before is a Draft (90 means withdrawn, but the document doesn't change anymore)

@ronaldtse
Copy link
Contributor Author

For ITU documents,

The //bibdata/status/:

  <status>
    <stage>in-force</stage>
  </status>

See https://www.metanorma.com/author/itu/authoring/

Screen Shot 2019-12-06 at 10 14 36 PM

@Intelligent2013
Copy link
Contributor

@ronaldtse
I've updated mn-iso.xsl for align with original ISO Rice document. In branch alex-xslt-update.
Align with PDF document is complicated than DOC, because in PDF there aren't any properties (margins, for example), and it's necessary to make a few steps - change xsl-fo, create pdf, compare two docs in Adobe Reader via ctrl-F6, then change xsl-fo, create pdf, compare, etc.

@ronaldtse
Copy link
Contributor Author

ronaldtse commented Dec 6, 2019

@Intelligent2013 Fully understand and appreciate your effort in aligning the PDFs in #40 !

Intelligent2013 added a commit that referenced this issue Dec 11, 2019
@Intelligent2013
Copy link
Contributor

Fixed. Comments please see in #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants