Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: ISO Rice (Chinese) review #434

Closed
anermina opened this issue Nov 2, 2020 · 4 comments
Closed

PDF: ISO Rice (Chinese) review #434

anermina opened this issue Nov 2, 2020 · 4 comments
Assignees
Labels

Comments

@anermina
Copy link

anermina commented Nov 2, 2020

PDF:

  1. Word "Cereals" is in different font.

image

  1. Baseline is not the same for the text in Chinese and the text in English (though we shouldn't have text in English, but word "ISO" should remain).

image

  1. Highlighted keywords should be in Chinese.

image
image
image

  1. "All rights reserved" is written in English, unlike in Word (currently we have this in English on odd and in Chinese on even pages in Word, as mentioned in Non-English (Chinese) document review: ISO Rice ZH #413).

image

Word or/and PDF:

  1. Cross-references to bibliography are blue and underlined in Word, unlike in PDF. Original document (in English) doesn't even have the cross-references here, so I'm not able to tell what is correct.

PDF:
image

Word:
image

  1. Footnote, note, key elements and figure caption are ordered differently after the corresponding figure.

The order in Word: caption, footnote, key elements, note.
image

The order in PDF: footnote, caption, key elements, note.
image

The order in original document (English version): key elements, footnote, note, caption.
image

@opoudjis
Copy link
Contributor

opoudjis commented Nov 4, 2020

@Intelligent2013 note that I have made edits to doc in related ticket #433;

  • Word or/and PDF issues: Blue is ok, and the figure rendering should be fixed in markup.

Use this PresentationXML:

rice-zh.zip

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Nov 5, 2020
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Nov 5, 2020
@Intelligent2013
Copy link
Contributor

1. Word "Cereals" is in different font.

Fixed:
изображение

2. Baseline is not the same for the text in Chinese and the text in English (though we shouldn't have text in English, but word "ISO" should remain).

Fixed:
изображение
изображение

3. Highlighted keywords should be in Chinese.

Fixed:
изображение
изображение
изображение
изображение

4. "All rights reserved" is written in English,

Fixed:
изображение

1. Cross-references to bibliography are blue and underlined in Word, unlike in PDF. Original document (in English) doesn't even have the cross-references here, so I'm not able to tell what is correct.

ISO xslt was updated earlier to align original PDF (metanorma/mn-native-pdf#35) which hasn't blue/underline style.
Example of original English PDF (https://github.com/metanorma/mn-samples-iso/blob/master/reference-docs/iso-rice-sample.pdf):
изображение

Example of resulted English PDF:
изображение
изображение

(I don't recall why Table reference blue/underlined...)

Example of resulted Chinese PDF:
изображение

@ronaldtse Would you like to set blue/underline for cross-references to bibliography for Chinese PDF only, or for English also?

2. Footnote, note, key elements and figure caption are ordered differently after the corresponding figure.

Fixed:
изображение

Resulted PDF in Chinese:
rice-zh.presentation.pdf

@Intelligent2013
Copy link
Contributor

Before closing this 3 years ago fixed issue I've tested it again for Issue 1 'Word "Cereals" is in different font.' and it occurred again:
image

Currently used fonts in fo:root: font-family="Noto Serif, Noto Serif SC, Cambria, Times New Roman,...
The font Noto Serif and Noto Serif SC have different baselines (yes, it's very strange). Current font selection strategy is auto (https://xmlgraphics.apache.org/fop/2.9/fonts.html#selection). Apache FOP 2.9 supports character-by-character strategy and upgrade to FOP 2.9 should solve this issue.

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Mar 27, 2024
@Intelligent2013
Copy link
Contributor

Fixed:
image

Done in https://github.com/metanorma/mn2pdf/releases/tag/v1.86 and will be available in the latest ISO XSLT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants