Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize icons #1025

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Optimize icons #1025

merged 1 commit into from
Apr 8, 2023

Conversation

ericfennis
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Added or changed icons

Icon X-rays icons/album.svg icons/alert-circle.svg icons/alert-octagon.svg icons/alert-triangle.svg icons/align-center.svg icons/align-end-horizontal.svg icons/align-end-vertical.svg icons/align-horizontal-distribute-center.svg icons/align-horizontal-distribute-end.svg icons/align-horizontal-distribute-start.svg icons/align-horizontal-justify-center.svg icons/align-horizontal-justify-end.svg icons/align-horizontal-justify-start.svg icons/align-horizontal-space-around.svg icons/align-horizontal-space-between.svg icons/align-justify.svg icons/align-left.svg icons/align-right.svg icons/align-start-horizontal.svg icons/align-start-vertical.svg icons/align-vertical-distribute-center.svg icons/align-vertical-distribute-end.svg icons/align-vertical-distribute-start.svg icons/align-vertical-justify-center.svg icons/align-vertical-justify-end.svg icons/align-vertical-justify-start.svg icons/align-vertical-space-around.svg icons/align-vertical-space-between.svg icons/anchor.svg icons/aperture.svg icons/archive-restore.svg icons/archive.svg icons/arrow-down-circle.svg icons/arrow-down-left.svg icons/arrow-down-right.svg icons/arrow-down.svg icons/arrow-left-circle.svg icons/arrow-left-right.svg icons/arrow-left.svg icons/arrow-right-circle.svg icons/arrow-right.svg icons/arrow-up-circle.svg icons/arrow-up-down.svg icons/arrow-up-left.svg icons/arrow-up-right.svg icons/arrow-up.svg icons/baby.svg icons/baggage-claim.svg icons/banknote.svg icons/bar-chart-2.svg icons/bar-chart.svg icons/bath.svg icons/battery-full.svg icons/battery-low.svg icons/battery-medium.svg icons/battery-warning.svg icons/battery.svg icons/bean-off.svg icons/beef.svg icons/binary.svg icons/bluetooth-connected.svg icons/bot.svg icons/box.svg icons/brain-circuit.svg icons/briefcase.svg icons/building.svg icons/calculator.svg icons/calendar-check-2.svg icons/calendar-check.svg icons/calendar-days.svg icons/calendar-minus.svg icons/calendar-off.svg icons/calendar-plus.svg icons/calendar-range.svg icons/calendar-x-2.svg icons/calendar-x.svg icons/calendar.svg icons/camera-off.svg icons/candy-off.svg icons/cast.svg icons/chef-hat.svg icons/chevron-down-square.svg icons/chevron-left-square.svg icons/chevron-right-square.svg icons/chevron-up-square.svg icons/chrome.svg icons/cigarette-off.svg icons/clipboard-check.svg icons/clipboard-copy.svg icons/clipboard-edit.svg icons/clipboard-list.svg icons/clipboard-signature.svg icons/clipboard-type.svg icons/clipboard-x.svg icons/clipboard.svg icons/codepen.svg icons/codesandbox.svg icons/coffee.svg icons/columns.svg icons/contact.svg icons/copy.svg icons/cpu.svg icons/credit-card.svg icons/crosshair.svg icons/currency.svg icons/delete.svg icons/diamond.svg icons/dice-1.svg icons/dice-2.svg icons/dice-3.svg icons/dice-4.svg icons/dice-5.svg icons/dice-6.svg icons/dices.svg icons/divide-circle.svg icons/divide-square.svg icons/divide.svg icons/dna-off.svg icons/dollar-sign.svg icons/download.svg icons/ear-off.svg icons/egg-off.svg icons/equal-not.svg icons/equal.svg icons/external-link.svg icons/eye-off.svg icons/feather.svg icons/file-digit.svg icons/file-lock-2.svg icons/file-lock.svg icons/file-minus.svg icons/file-plus.svg icons/file-text.svg icons/file-video-2.svg icons/file-x.svg icons/film.svg icons/fish-off.svg icons/flag-off.svg icons/flag.svg icons/flashlight-off.svg icons/flashlight.svg icons/flask-conical-off.svg icons/folder-lock.svg icons/folder-minus.svg icons/folder-plus.svg icons/forklift.svg icons/form-input.svg icons/frame.svg icons/frown.svg icons/fuel.svg icons/function-square.svg icons/gamepad-2.svg icons/gamepad.svg icons/gift.svg icons/git-branch.svg icons/git-commit.svg icons/git-pull-request-closed.svg icons/git-pull-request-draft.svg icons/git-pull-request.svg icons/globe.svg icons/grid.svg icons/hard-drive.svg icons/hash.svg icons/heart-off.svg icons/help-circle.svg icons/hop-off.svg icons/ice-cream-2.svg icons/image-minus.svg icons/image-off.svg icons/image-plus.svg icons/image.svg icons/indent.svg icons/info.svg icons/instagram.svg icons/italic.svg icons/keyboard.svg icons/landmark.svg icons/laptop-2.svg icons/laugh.svg icons/layout-dashboard.svg icons/layout-grid.svg icons/layout-list.svg icons/layout.svg icons/life-buoy.svg icons/lightbulb.svg icons/link-2-off.svg icons/link-2.svg icons/linkedin.svg icons/list-checks.svg icons/list-ordered.svg icons/list.svg icons/loader.svg icons/lock.svg icons/log-in.svg icons/log-out.svg icons/mail.svg icons/mails.svg icons/map-pin-off.svg icons/map.svg icons/maximize-2.svg icons/meh.svg icons/menu.svg icons/mic-off.svg icons/mic.svg icons/microwave.svg icons/milk-off.svg icons/minimize-2.svg icons/minus-circle.svg icons/minus-square.svg icons/minus.svg icons/monitor-smartphone.svg icons/monitor-speaker.svg icons/monitor.svg icons/mouse.svg icons/move-diagonal-2.svg icons/move-diagonal.svg icons/move-horizontal.svg icons/move-vertical.svg icons/move.svg icons/navigation-2-off.svg icons/navigation-off.svg icons/network.svg icons/nfc.svg icons/nut-off.svg icons/outdent.svg icons/package-check.svg icons/package-minus.svg icons/package-open.svg icons/package-plus.svg icons/package-search.svg icons/package-x.svg icons/package.svg icons/pause-circle.svg icons/pause.svg icons/pencil.svg icons/percent.svg icons/phone-forwarded.svg icons/phone-incoming.svg icons/phone-missed.svg icons/phone-off.svg icons/phone-outgoing.svg icons/picture-in-picture-2.svg icons/picture-in-picture.svg icons/pin-off.svg icons/pin.svg icons/plus-circle.svg icons/plus-square.svg icons/plus.svg icons/power.svg icons/printer.svg icons/qr-code.svg icons/radio-receiver.svg icons/rectangle-horizontal.svg icons/rectangle-vertical.svg icons/rocking-chair.svg icons/scale-3d.svg icons/scan-line.svg icons/scissors.svg icons/search.svg icons/send.svg icons/separator-horizontal.svg icons/separator-vertical.svg icons/server.svg icons/share-2.svg icons/share.svg icons/sheet.svg icons/shield-close.svg icons/shield-off.svg icons/shopping-bag.svg icons/shuffle.svg icons/sidebar-close.svg icons/sidebar-open.svg icons/sidebar.svg icons/skip-back.svg icons/skip-forward.svg icons/slack.svg icons/slash.svg icons/sliders-horizontal.svg icons/sliders.svg icons/smartphone-charging.svg icons/smartphone-nfc.svg icons/smartphone.svg icons/smile-plus.svg icons/smile.svg icons/snowflake.svg icons/speaker.svg icons/square.svg icons/star-off.svg icons/stop-circle.svg icons/stretch-horizontal.svg icons/stretch-vertical.svg icons/strikethrough.svg icons/sword.svg icons/swords.svg icons/table.svg icons/tablet.svg icons/terminal-square.svg icons/terminal.svg icons/toggle-left.svg icons/toggle-right.svg icons/toy-brick.svg icons/train.svg icons/trash-2.svg icons/trello.svg icons/tv-2.svg icons/tv.svg icons/type.svg icons/umbrella.svg icons/underline.svg icons/unlink.svg icons/unlock.svg icons/upload.svg icons/user-minus.svg icons/user-plus.svg icons/user-x.svg icons/vibrate-off.svg icons/vibrate.svg icons/video-off.svg icons/video.svg icons/voicemail.svg icons/volume-x.svg icons/wheat-off.svg icons/wifi-off.svg icons/wifi.svg icons/wine-off.svg icons/wrap-text.svg icons/x-circle.svg icons/x-octagon.svg icons/x-square.svg icons/x.svg icons/zap-off.svg icons/zoom-in.svg icons/zoom-out.svg

@danielbayley
Copy link
Member

I feel like there should be some kind of CI process/pre-commit hook (maybe using svgo, along with possibly one or more plugins even) to automate some of this kind of thing…

@karsa-mistmere
Copy link
Member

There is.

@danielbayley
Copy link
Member

There is.

Ah nice! I hadn’t done pnpm install and so husky wasn’t running the pre-commit hook…

Although it seems things like, for example:

class="s01"

added by Illustrator slip through…

I seem to remember making a note to put together an svgo plugin to remove these myself, but life got in the way…

Can it still not be done without a plugin?

@ericfennis
Copy link
Member Author

@danielbayley You can run pnpm optimize manually.

@ericfennis ericfennis merged commit f620c85 into lucide-icons:main Apr 8, 2023
@danielbayley
Copy link
Member

@danielbayley You can run pnpm optimize manually.

Nice, yeah I had been running npx svgo before…

Should pnpm optimize not be in the pre-commit hook too?

It still doesn’t remove e.g class="st0" output from Illustrator mind…

@karsa-mistmere
Copy link
Member

No, we only optimize staged icons in the pre commit hook (see pnpm lint-staged).

@garikAsplund
Copy link

It'd be nice to have a snowflake with 6 arms instead of 4. Should be simple enough. 🙏

@karsa-mistmere
Copy link
Member

It'd be nice to have a snowflake with 6 arms instead of 4. Should be simple enough. 🙏

I have one in my drafts already, I'll post it asap.
It's also been bugging me, since real life snowflakes always have sixfold symmetry.

@garikAsplund
Copy link

Excellent--appreciate it!! I know there are a couple other icons in the mix that have the same unnatural snowflake as part of their design. See here.

@karsa-mistmere
Copy link
Member

Excellent--appreciate it!! I know there are a couple other icons in the mix that have the same unnatural snowflake as part of their design. See here.

PR now open: #2610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants