Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add panel-* icons #1003

Merged
merged 18 commits into from
Apr 28, 2023
Merged

Add panel-* icons #1003

merged 18 commits into from
Apr 28, 2023

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Mar 30, 2023 •
edited
Loading

This PR aims to complete the existing sidebar-* set of icons, cover the layout[-panel]-* codicons and consolidate everything into a more coherent subset of icons. Closes #1059.

@danielbayley danielbayley force-pushed the panel branch 2 times, most recently from b5711cc to ce80d1d Compare March 30, 2023 15:46
@danielbayley danielbayley changed the title Add panel icon Add panel and sidebar-* icons Mar 30, 2023
@danielbayley danielbayley changed the title Add panel and sidebar-* icons Add panel and sidebar-*[-inactive] icons Mar 30, 2023
@karsa-mistmere
Copy link
Member

I also have these in my drafts (sidebar-open, sidebar-close), what do you think of also adding these?
image

@ericfennis
Copy link
Member

@karsa-mistmere I think we have already some of these

ericfennis
ericfennis reviewed Apr 5, 2023
View reviewed changes
@karsa-mistmere
Copy link
Member

@karsa-mistmere I think we have already some of these

Sure, I meant just the matching pairs for the new orientation. :)

@danielbayley
Copy link
Member Author

@karsa-mistmere I think we have already some of these

Yeah https://lucide.dev/?search=sidebar just sidebar-open/close, which should be renamed to sidebar-left-open/close…

@github-actions
Copy link

github-actions bot commented Apr 6, 2023 •
edited
Loading

Added or changed icons

Icon X-rays icons/panel-bottom-close.svg icons/panel-bottom-inactive.svg icons/panel-bottom-open.svg icons/panel-bottom.svg icons/panel-left-close.svg icons/panel-left-inactive.svg icons/panel-left-open.svg icons/panel-left.svg icons/panel-right-close.svg icons/panel-right-inactive.svg icons/panel-right-open.svg icons/panel-right.svg icons/panel-top-close.svg icons/panel-top-inactive.svg icons/panel-top-open.svg icons/panel-top.svg

@danielbayley danielbayley changed the title Add panel and sidebar-*[-inactive] icons Add panel and sidebar-*[-inactive]/open/close icons Apr 6, 2023
@karsa-mistmere
Copy link
Member

@danielbayley If we rename them, we'll have to add aliases for their old names.

@danielbayley danielbayley mentioned this pull request Apr 11, 2023
Merged
@danielbayley
Copy link
Member Author

@danielbayley If we rename them, we'll have to add aliases for their old names.

Done.

@danielbayley danielbayley requested a review from ericfennis April 11, 2023 17:31
@danielbayley danielbayley changed the title Add panel and sidebar-*[-inactive]/open/close icons Add panel, menu-bar and sidebar-*[-inactive]/open/close icons Apr 11, 2023
@karsa-mistmere
Copy link
Member

Not super sure about the names panel and menu-bar, it'd be neat if we could come up with a single name that works for both ...-bottom and ...-top.

I've seen UI libs use the names drawer, sheet and slide-over for all four placements, but I'm not totally sold on either of these.

@danielbayley
Copy link
Member Author

danielbayley commented Apr 13, 2023 •
edited
Loading

Not super sure about the names panel and menu-bar, it'd be neat if we could come up with a single name that works for both ...-bottom and ...-top.

I've seen UI libs use the names drawer, sheet and slide-over for all four placements, but I'm not totally sold on either of these.

@karsa-mistmere What do you think of just naming all of these (including the existing sidebar-* icons) simply panel-*, and then adding tags for sidebar/menu/status/bar etc…?

@karsa-mistmere
Copy link
Member

I think the dashed lines should fall more in line with pre-existing dashed lines (box-select, ticket, flip-*), in this case box-select in particular (the dash array of flip just doesn't work here):
image

@danielbayley
Copy link
Member Author

dashed lines should fall more in line with pre-existing dashed lines

@karsa-mistmere pushed…

ericfennis
ericfennis approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for you changes!

@ericfennis ericfennis merged commit 701f2a1 into lucide-icons:main Apr 28, 2023
@danielbayley danielbayley deleted the panel branch April 28, 2023 07:41
danielbayley added a commit to danielbayley/lucide that referenced this pull request Apr 28, 2023
@danielbayley
Fix removal of sidebar.json
d207e11 
Not sure what happened, but `sidebar.json` should have been deleted when replaced with
`panel-left.json` in lucide-icons#1003… This is currently breaking the `pre-commit` hook!
@danielbayley danielbayley mentioned this pull request Apr 28, 2023
Merged
karsa-mistmere pushed a commit that referenced this pull request Apr 28, 2023
@danielbayley
Fix removal of sidebar.json (#1174)
de629f0 
Not sure what happened, but `sidebar.json` should have been deleted when replaced with
`panel-left.json` in #1003… This is currently breaking the `pre-commit` hook!
This was referenced Apr 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis approved these changes

@karsa-mistmere karsa-mistmere karsa-mistmere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbayley @karsa-mistmere @ericfennis @jguddas