-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): upgrade snowflake icons to match real life #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added or changed iconsIcons as codeWorks for: const SnowflakeIcon = createLucideIcon('Snowflake', [
["path",{"d":"m10 20-1.25-2.5L6 18"}],
["path",{"d":"M10 4 8.75 6.5 6 6"}],
["path",{"d":"m14 20 1.25-2.5L18 18"}],
["path",{"d":"m14 4 1.25 2.5L18 6"}],
["path",{"d":"m17 21-3-6h-4"}],
["path",{"d":"m17 3-3 6 1.5 3"}],
["path",{"d":"M2 12h6.5L10 9"}],
["path",{"d":"m20 10-1.5 2 1.5 2"}],
["path",{"d":"M22 12h-6.5L14 15"}],
["path",{"d":"m4 10 1.5 2L4 14"}],
["path",{"d":"m7 21 3-6-1.5-3"}],
["path",{"d":"m7 3 3 6h4"}]
])
const SunSnowIcon = createLucideIcon('SunSnow', [
["path",{"d":"M10 21v-1"}],
["path",{"d":"M10 4V3"}],
["path",{"d":"M10 9a3 3 0 0 0 0 6"}],
["path",{"d":"m14 20 1.25-2.5L18 18"}],
["path",{"d":"m14 4 1.25 2.5L18 6"}],
["path",{"d":"m17 21-3-6 1.5-3H22"}],
["path",{"d":"m17 3-3 6 1.5 3"}],
["path",{"d":"M2 12h1"}],
["path",{"d":"m20 10-1.5 2 1.5 2"}],
["path",{"d":"m3.64 18.36.7-.7"}],
["path",{"d":"m4.34 6.34-.7-.7"}]
])
const ThermometerSnowflakeIcon = createLucideIcon('ThermometerSnowflake', [
["path",{"d":"m10 20-1.25-2.5L6 18"}],
["path",{"d":"M10 4 8.75 6.5 6 6"}],
["path",{"d":"M10.585 15H10"}],
["path",{"d":"M2 12h6.5L10 9"}],
["path",{"d":"M20 14.54a4 4 0 1 1-4 0V4a2 2 0 0 1 4 0z"}],
["path",{"d":"m4 10 1.5 2L4 14"}],
["path",{"d":"m7 21 3-6-1.5-3"}],
["path",{"d":"m7 3 3 6h2"}]
]) |
Merged
What about arcifying the inner hexagon? |
jguddas
approved these changes
Nov 13, 2024
jguddas
approved these changes
Dec 18, 2024
ericfennis
approved these changes
Dec 20, 2024
ehsanpo
added a commit
to ehsanpo/portfolio-astro
that referenced
this pull request
Jan 23, 2025
 <h3>Snyk has created this PR to upgrade lucide-react from 0.468.0 to 0.469.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released **24 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>lucide-react</b></summary> <ul> <li> <b>0.469.0</b> - <a href="https://redirect.github.com/lucide-icons/lucide/releases/tag/0.469.0">2024-12-20</a></br><h2>Modified Icons 🔨</h2> <ul> <li><code>snowflake</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2654710561" data-permission-text="Title is private" data-url="lucide-icons/lucide#2610" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2610/hovercard" href="https://redirect.github.com/lucide-icons/lucide/pull/2610">#2610</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/karsa-mistmere">@ karsa-mistmere</a></li> <li><code>sun-snow</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2654710561" data-permission-text="Title is private" data-url="lucide-icons/lucide#2610" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2610/hovercard" href="https://redirect.github.com/lucide-icons/lucide/pull/2610">#2610</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/karsa-mistmere">@ karsa-mistmere</a></li> <li><code>thermometer-snowflake</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2654710561" data-permission-text="Title is private" data-url="lucide-icons/lucide#2610" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2610/hovercard" href="https://redirect.github.com/lucide-icons/lucide/pull/2610">#2610</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/karsa-mistmere">@ karsa-mistmere</a></li> </ul> </li> <li> <b>0.468.0</b> - <a href="https://redirect.github.com/lucide-icons/lucide/releases/tag/0.468.0">2024-12-05</a></br><h2>New icons 🎨</h2> <ul> <li><code>waves-ladder</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2583351399" data-permission-text="Title is private" data-url="lucide-icons/lucide#2529" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2529/hovercard" href="https://redirect.github.com/lucide-icons/lucide/pull/2529">#2529</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jguddas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/jguddas">@ jguddas</a></li> </ul> </li> </ul> from <a href="https://redirect.github.com/lucide-icons/lucide/releases">lucide-react GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzYzg0NDU4My00MTRlLTQzMTUtODE3OC1mMTNkNzMxZDA5MjYiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjNjODQ0NTgzLTQxNGUtNDMxNS04MTc4LWYxM2Q3MzFkMDkyNiJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/ehsanpo/project/c2f36089-d689-4396-baf9-72eeb1880e6c?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/ehsanpo/project/c2f36089-d689-4396-baf9-72eeb1880e6c/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/ehsanpo/project/c2f36089-d689-4396-baf9-72eeb1880e6c/settings/integration?pkg=lucide-react&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"lucide-react","from":"0.468.0","to":"0.469.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"3c844583-414e-4315-8178-f13d731d0926","prPublicId":"3c844583-414e-4315-8178-f13d731d0926","packageManager":"npm","priorityScoreList":[],"projectPublicId":"c2f36089-d689-4396-baf9-72eeb1880e6c","projectUrl":"https://app.snyk.io/org/ehsanpo/project/c2f36089-d689-4396-baf9-72eeb1880e6c?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-12-20T09:39:50.989Z"},"vulns":[]}'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Real snowflakes have six-fold rotational symmetry, this PR upgrades snowflake icons to look more accurate and have better uniformity between them.
Before Submitting