AWS – use session.NewSession instead of session.New to
#2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`session.New` is deprecated and requires the `AWS_SDK_LOAD_CONFIG` environment variable to be set in order to automatically call `AssumeRoleWithWebIdentity` when `AWS_WEB_IDENTITY_TOKEN_FILE` is set (which is not documented and most likely unintended).
k8s-ci-robot
added
cncf-cla: yes
|
Original bug report: aws/aws-sdk-go#2828 |
|
/assign @Jeffwan |
|
Thanks for the change. This would be an easy way no matter /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Oct 8, 2019
This was referenced Oct 11, 2019
Closed
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 17, 2019
Cherry pick #2428 to 1.13
andrewward
added a commit
to andrewward/cwlogstream_exporter
that referenced
this pull request
Aug 28, 2020
Due to the way the AWS's pod identity webhook provides authentication tokens to pods, we need to upgrade `aws-sdk-go` as per https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html and use replace the deprecated New func with NewSession to properly load the identity file as detailed in this issue: kubernetes/autoscaler#2428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session.Newis deprecated and requires theAWS_SDK_LOAD_CONFIGenvironment variable to be set in order to automatically call
AssumeRoleWithWebIdentitywhenAWS_WEB_IDENTITY_TOKEN_FILEis set(which is not documented and most likely unintended).