Cluster Autoscaler patch release - request for cherry-picks

[losipiuk]

We plan to prepare a set of Cluster Autoscaler patch releases beginning next week. Please issue cherry-picks if you want something in. Just a friendly reminder that as a rule of thumb only bugfixes are cherry-pickable.

cc: @feiskyer, @Jeffwan, @ringtail, @hello2mao, @tghartland

[feiskyer]

@losipiuk thanks for reminding. No cherry-picks from me.

[Jeffwan]

I will finish cherry-pick by this Thursday.
Candidates:
#2428 to all branches with IAM pods support
#2401 to v1.12+
#2385 to versions with Launch Template support

[ringtail]

@losipiuk thanks for reminding. No cherry-picks from Alibaba Cloud.

[alfredkrohmer]

Would it be possible to include the AWS SDK updates that enable IAM roles for service accounts? There is already a PR to merge the update into 1.14: #2358 I can confirm that this works and together with my PR #2428 also without the workaround.

[losipiuk]

Would it be possible to include the AWS SDK updates that enable IAM roles for service accounts? There is already a PR to merge the update into 1.14: #2358 I can confirm that this works and together with my PR #2428 also without the workaround.

@Jeffwan WDYT? It is kinda massive change. Larger than we typically allow for patch releases - and not strictly a bugfix. Yet I think we can merge that if you approve. If so I think we should also cherry pick #2428

[Jeffwan]

@losipiuk Totally understand the policy, this one is all about godeps changes just for aws SDK.
We will appreciate if this can be merged to 1.14. otherwise, our pod IAM feature can not run on any EKS cluster (AWS supports 1.11-1.14)

#2428 is in the cherry-pick list, I will do that. Thanks a lot!

BTW, I check comments in #2356
Will we update vendor for release branches later? Sounds like there's risk to overwrite the changes.

[Jeffwan]

Here's the cherry-pick changes. Thanks! @losipiuk

#2443 #2442 #2441 #2440

[Jeffwan]

Looks like there're two related to priority expander.
#2435 #1920
Do we have plans to backport to older version?

[Jeffwan]

All AWS changes are done. Thanks! @losipiuk

[losipiuk]

Just heads up that I am kinda overwhelmed with other stuff so the patch release my slip a bit. Still I want to do that this week.

[losipiuk]

Released:
https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.13.8
https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.14.6
https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.15.3
https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.16.2