Skip to content

Commit

Permalink
Merge pull request #2464 from Jeffwan/cherry-pick-1.13
Browse files Browse the repository at this point in the history
Cherry pick #2428 to 1.13
  • Loading branch information
k8s-ci-robot authored Oct 17, 2019
2 parents 1118e37 + f2f5c1a commit bf9c2fe
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions cluster-autoscaler/cloudprovider/aws/aws_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,14 @@ type asgTemplate struct {
func getRegion(cfg ...*aws.Config) string {
region, present := os.LookupEnv("AWS_REGION")
if !present {
svc := ec2metadata.New(session.New(), cfg...)
if r, err := svc.Region(); err == nil {
region = r
sess, err := session.NewSession()
if err != nil {
klog.Errorf("Error getting AWS session while retrieving region: %v", err)
} else {
svc := ec2metadata.New(sess, cfg...)
if r, err := svc.Region(); err == nil {
region = r
}
}
}
return region
Expand All @@ -95,7 +100,10 @@ func createAWSManagerInternal(
}

if autoScalingService == nil || ec2Service == nil {
sess := session.New(aws.NewConfig().WithRegion(getRegion()))
sess, err := session.NewSession(aws.NewConfig().WithRegion(getRegion()))
if err != nil {
return nil, err
}

if autoScalingService == nil {
autoScalingService = &autoScalingWrapper{autoscaling.New(sess), map[string]string{}}
Expand Down

0 comments on commit bf9c2fe

Please sign in to comment.