[Backport release-1.25] Use custom log writer for stdout/err in supervisor #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The io.Writer implementation provided by logrus refuses to write
lines that are longer than 64k. An error is logged and the log pipe is
closed. This will cause the stdout or stderr of the supervised process
to be broken ("broken pipe"). Depending on the supervised process, the
result may vary. At a minimum, k0s will no longer log anything from the
affected processes. Some processes (e.g. the kubelet) will terminate
themselves when trying to use stdout/stderr, resulting in a restart.
Use a custom io.Writer instead. It will do pretty much the same thing as
logrus's one, but it will chunk long lines into multiple log statements.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
(cherry picked from commit 46f816f)
(cherry picked from commit 269b790)
twz123
changed the title
twz123
added
bug
jnummelin
approved these changes
Feb 7, 2023
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.24
git worktree add -d .worktree/backport-2694-to-release-1.24 origin/release-1.24
cd .worktree/backport-2694-to-release-1.24
git checkout -b backport-2694-to-release-1.24
ancref=$(git merge-base 400eb75704a14e4094c8fa344623c05e90cfdd0a 5eca556d4673df3a2ebe81128980956e433f2470)
git cherry-pick -x $ancref..5eca556d4673df3a2ebe81128980956e433f2470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.25, triggered by a label in #2688.See #2674.