Use custom log writer for stdout/err in supervisor #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
force-pushed
the
supervisor-logging
branch
2 times, most recently
from
6d8cd90 to
8da28f9
Compare
kke
reviewed
Feb 2, 2023
twz123
force-pushed
the
supervisor-logging
branch
from
8da28f9 to
b4f2226
Compare
4 tasks
twz123
force-pushed
the
supervisor-logging
branch
from
b4f2226 to
fa89caf
Compare
The io.Writer implementation provided by logrus refuses to write
lines that are longer than 64k. An error is logged and the log pipe is
closed. This will cause the stdout or stderr of the supervised process
to be broken ("broken pipe"). Depending on the supervised process, the
result may vary. At a minimum, k0s will no longer log anything from the
affected processes. Some processes (e.g. the kubelet) will terminate
themselves when trying to use stdout/stderr, resulting in a restart.
Use a custom io.Writer instead. It will do pretty much the same thing as
logrus's one, but it will chunk long lines into multiple log statements.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
supervisor-logging
branch
from
fa89caf to
46f816f
Compare
twz123
added
the
backport/release-1.26
|
Successfully created backport PR for |
This was referenced Feb 7, 2023
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
io.Writerimplementation provided by logrus refuses to write lines that are longer than 64k. An error is logged and the log pipe is closed. This will cause the stdout or stderr of the supervised process to be broken ("broken pipe"). Depending on the supervised process, the result may vary. At a minimum, k0s will no longer log anything from the affected processes. Some processes (e.g. the kubelet) will terminate themselves when trying to use stdout/stderr, resulting in a restart.Use a custom
io.Writerinstead. It will do pretty much the same thing as logrus's one, but it will chunk long lines into multiple log statements.See:
Type of change
How Has This Been Tested?
Checklist: