Add additional checks to NativeECDHKeyAgreement to match upstream #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostasTsiounis
force-pushed
the
ecdh_change
branch
from
4e49aae to
441e130
Compare
keithc-ca
requested changes
May 13, 2024
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
KostasTsiounis
force-pushed
the
ecdh_change
branch
from
39fbef1 to
47af2d6
Compare
KostasTsiounis
force-pushed
the
ecdh_change
branch
from
b666c05 to
dab7253
Compare
|
Jenkins test sanity zlinux jdknext |
|
The two test failures (java.security.manager) in a grinder seem unrelated to this change. |
keithc-ca
approved these changes
May 14, 2024
This was referenced May 15, 2024
|
@keithc-ca pls see the backports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are additional checks that are required during the
initanddoPhaseparts ofECDHkey agreement. Those checks are already present in the originalECDHKeyAgreementclass, so they had to be added to theNativeECDHKeyAgreementclass as well.Both the private and public key are, also, set to null at the beginning of the initialization, regardless of the method's outcome, meaning that in case of failure the previous keys cannot be used. This is new in JDK23.
Fixes: eclipse-openj9/openj9#19437
Signed-off by: Kostas Tsiounis kostas.tsiounis@ibm.com