Add additional checks to NativeECDHKeyAgreement to match upstream #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @keithc-ca |
KostasTsiounis
force-pushed
the
ecdh_change
branch
from
d8ed993 to
aed517c
Compare
keithc-ca
requested changes
May 23, 2024
closed/adds/jdk/src/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/adds/jdk/src/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
KostasTsiounis
force-pushed
the
ecdh_change
branch
from
20d5f8a to
0773956
Compare
|
Jenkins test sanity alinux jdk8 |
|
Grinders:
Please assess the failures in jdk_security3. |
|
The The other one doesn't seem |
|
Grinder for jdk_security3 passed with the nightly build: https://openj9-jenkins.osuosl.org/job/Grinder/3627. |
|
It seems to be machine depended. It doesn't fail everywhere apparently. |
|
Grinder for jdk_security3 passed in https://openj9-jenkins.osuosl.org/job/Grinder/3628 (running on the same machine as used by https://openj9-jenkins.osuosl.org/job/Grinder/3627). |
keithc-ca
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are additional checks that are required during the
initanddoPhaseparts ofECDHkey agreement. Those checks are already present in the originalECDHKeyAgreementclass, so they had to be added to theNativeECDHKeyAgreementclass as well.Back-ported from: ibmruntimes/openj9-openjdk-jdk#788
Signed-off by: Kostas Tsiounis kostas.tsiounis@ibm.com